From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB2BEA0C44; Mon, 12 Apr 2021 10:25:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7F96F4068E; Mon, 12 Apr 2021 10:25:41 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 0C2154014E; Mon, 12 Apr 2021 10:25:40 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 7024A5C0107; Mon, 12 Apr 2021 04:25:39 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 12 Apr 2021 04:25:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= 7OmxGNI5bI2t0o+yaibyMxMFIAs1XIpE2DN524O+Ugs=; b=KJmQ9C8eQsnNs/Wq ozXDfccOQD5wQijNGNfzDK4eRAjxb5O3CIIY2rdkW99/Ssi1MAHpXKq281dthspW FVgV9iQ1dGzTPipu1boMV6+1dhWakUcXKDPlhQSU2AOROseStB4KP2s71MxgU9BE rhpSkrA7w+aKYGUzBnZCmDhEteZEidAErFlZy9zgwyP/RyBcHEHIzBlpnnnyh8eD UvMScSA/wm577iSW1UTiyYvrz5DWPNo9LXzsZxcBacigIVwvQU4StwotSerHCYGa uffOkxr6sSHD6IVLARip2BdHfXcjLKmNhX0A3LJZ6Sp+XhMgvdOy/dpJuDNhxwog kZk0nw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=7OmxGNI5bI2t0o+yaibyMxMFIAs1XIpE2DN524O+U gs=; b=mZnR9QXk6ktEg+kgmvV9QN0mzo+cETuIlHIP3W7oOY5jVYYZQ3QSqCs8A n8ky3Q3ouCaQ0kBgOUBhC7w1DUoxn+hgbbCrMdtgqhS3qa5Dl3dxTvIQbFaO99lZ V+WEa2U2Y54ii5LKhnsZUwJB67kiyQAfbYT03o1gvaKRn4NZE1PmuT8uxUIQf44y Venn5m9j84+AqyhGCXNdWPf1muQtDF2ih0xmLIYqLVBR+5iWPiQK1joTdWcau1VK sfxrb+7J/8XJhuL2UjpI9BCff1Q7hbXGT0Q9RVqeisANMP+RKoSdXb95Q/p5+FIH EXzCZyzF/BJgss47MxoyoItfqLMbw== X-ME-Sender: <xms:AgR0YKLTmbhyskuACRmTRd3dSipqIY_OjIPdHujsoyMYnI4Owg6txw> <xme:AgR0YCLE8KpTl41njIf-VUEwcHVwdo4lJVe9tJVVoO1nFV2GlFSoVFKY0e5hr_8p7 Rs6o_8qYIqWbfmhRA> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudekjedgtdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepkeethedtieevhfeigeejleegudefjeehkeekteeuveeiuedvveeu tdejveehveetnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: <xmx:AgR0YKtmcltr5NJYrsAB8KCLgaArGxm_-aZUiuoKR41ThJ7vOsxHmQ> <xmx:AgR0YPbEeuyKgzn-mrK3kxPsjdHxEbplgV6DxxIlBupSRJ1u8supvQ> <xmx:AgR0YBalRiBSopu96l2ftK7AajUAEYHxifreE9xr_rYoPRUMI9uOtw> <xmx:AwR0YGNli2N1gah2G7HVAIjsvF9VmO_6QbrxmhQ0xTAjH6q4XfxVhw> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id F07661080069; Mon, 12 Apr 2021 04:25:37 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, Tal Shnaiderman <talshn@nvidia.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, "pallavi.kadam@intel.com" <pallavi.kadam@intel.com>, "navasile@linux.microsoft.com" <navasile@linux.microsoft.com>, "dmitrym@microsoft.com" <dmitrym@microsoft.com>, "david.marchand@redhat.com" <david.marchand@redhat.com>, "lucp.at.work@gmail.com" <lucp.at.work@gmail.com>, "stable@dpdk.org" <stable@dpdk.org> Date: Mon, 12 Apr 2021 10:25:35 +0200 Message-ID: <1998989.grVXzi9dvb@thomas> In-Reply-To: <DM6PR12MB3945DF27B2FB8A2D2A0CD604A4709@DM6PR12MB3945.namprd12.prod.outlook.com> References: <20210410195433.13416-1-talshn@nvidia.com> <20210412000035.77a1f0f6@sovereign> <DM6PR12MB3945DF27B2FB8A2D2A0CD604A4709@DM6PR12MB3945.namprd12.prod.outlook.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eal/windows: fix pthreads macros return values X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 12/04/2021 09:59, Tal Shnaiderman: > > Subject: Re: [PATCH] eal/windows: fix pthreads macros return values > >=20 > > External email: Use caution opening links or attachments > >=20 > >=20 > > Hi Tal, > >=20 > > Getting warnings from x86_64-w64-mingw32-gcc (GCC) 9.3.0: > >=20 > > ../../../lib/librte_eal/common/eal_common_thread.c: In function > > =E2=80=98ctrl_params_free=E2=80=99: > > ../../../lib/librte_eal/windows/include/pthread.h:42:2: warning: value > > computed is not used [-Wunused-value] > > 42 | !DeleteSynchronizationBarrier(barrier) > >=20 > > Probably applies to other functions and may fire in combination with fu= ture > > backported patches. Hopefully since 21.05 there will be new threading A= PI. >=20 > Thanks Dmitry, it's odd that the compiler complains only now, I'd expect = to see this warning even before the change. >=20 > Do we know if the new threading API will be in 21.05? API changes close i= n 3 days and I didn't see it get reviewed/acked. Yes it seems too short for 21.05. > I can change only pthread_barrier_init for now, since currently without t= his change Windows runtime is broken, what do you think?=20