DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, stable@dpdk.org,
	Olivier Matz <olivier.matz@6wind.com>,
	Bruce Richardson <bruce.richardson@intel.com>,
	Ranjit Menon <ranjit.menon@intel.com>, Aaron <aconole@redhat.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] build: fix using ELF-only linker flags with COFF
Date: Wed, 13 Jan 2021 21:55:12 +0100	[thread overview]
Message-ID: <1999240.RY27NfppNA@thomas> (raw)
In-Reply-To: <abda0119-628e-8874-d7ff-abc57265c0a8@intel.com>

13/01/2021 21:27, Ranjit Menon:
> On 1/11/2021 4:36 PM, Dmitry Kozlyuk wrote:
> > The --export-dynamic linker option is only applicable to ELF.
> > On Windows, where COFF is used, it causes warnings:
> >
> >      x86_64-w64-mingw32-ld: warning: --export-dynamic is not supported
> >      for PE+ targets, did you mean --export-all-symbols? (MinGW)
> >
> >      LINK : warning LNK4044: unrecognized option '/-export-dynamic';
> >      ignored (clang)
> >
> > Don't add --export-dynamic on Windows anywhere.
> >
> > Fixes: b031e13d7f0d ("build: fix plugin load on static build")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> > ---
> > Using TLS variables with DLLs is problematic on Windows for now,
> > so not attempting to check or solve the issue with plugin load.
> 
> Acked-by: Ranjit Menon <ranjit.menon@intel.com>

Applied, thanks

Why we didn't catch it in advance in CI?



  reply	other threads:[~2021-01-13 20:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-12  0:36 [dpdk-dev] " Dmitry Kozlyuk
2021-01-13 20:27 ` Ranjit Menon
2021-01-13 20:55   ` Thomas Monjalon [this message]
2021-01-14  9:27     ` [dpdk-dev] [dpdk-stable] " Tal Shnaiderman
2021-01-14  9:30       ` Thomas Monjalon
2021-01-14 10:30         ` Tal Shnaiderman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1999240.RY27NfppNA@thomas \
    --to=thomas@monjalon.net \
    --cc=aconole@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=olivier.matz@6wind.com \
    --cc=ranjit.menon@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).