From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id D3FADA0A02;
Wed, 13 Jan 2021 21:55:22 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 5C05F140D38;
Wed, 13 Jan 2021 21:55:22 +0100 (CET)
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
[66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 0CC8A140D36;
Wed, 13 Jan 2021 21:55:21 +0100 (CET)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
by mailout.nyi.internal (Postfix) with ESMTP id A119C5C0186;
Wed, 13 Jan 2021 15:55:20 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
by compute4.internal (MEProxy); Wed, 13 Jan 2021 15:55:20 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm3; bh=
M2WmQhsLC1P4BkN/9m3VsN4wY6V8CTrID1va48qpbUU=; b=H7XCFay+KGsAOB02
grHiwxq9h84my1yyt8ivbB7OyzXr2dqpfa7tnBSWAtuSYDapcgMB121g7ULB8oqj
ePSTaTC4z33f1frHGd1aFbyAsAd/teX0mbUeEHx9PDWsqdCHzDpqfEonSrDfeAtj
aCf63WU7TsF/MubQ/r+2zE+xlk6nfK37fNf02zh/5Bykj7e5TZ9O+2nPFOxB/roj
6fiX8xOskqszIeN8DEKlG6sdwIg98tf5p19FiMWhVOsWYXMDQ8nUT+BxzY47x/he
CAp6DfTTYXlVVAJx2DVjXZUiku2v6Vd4nTrksgjReTs3ejNcRfx3QVQWn140JPqX
UB+k7g==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm1; bh=M2WmQhsLC1P4BkN/9m3VsN4wY6V8CTrID1va48qpb
UU=; b=ocufUwShn/UtHPO9IBi3lHP2LHmE07S8/rNI6ENcylwugfZAdRLeVt2sx
TkD0LAyhyCLpNlRkyWcS6olAhU/MbhByg2GPQVnoFFpq2U3/0jqlmASqb5PilQrE
/iXmr/g/p9O3+Il0h+z5/P/KDrAFyCsXelDvV/V9Xjx7vNkOEDQsNDTNu5K9dSV0
hYnwH4DYJyGzlVtUnZx6i9adhojsppaKUjSbiKpdCwSNLob08rwvJ9Dp3h2xKm9g
gl1Gc56bg/GS5vYy7Aou97Vsj0bBDMK1jOEaAziK3qJ8VTvkKGEcFHL3qX6dAJxw
prjvMhC90iPlkgTMlPq8zU+qExOrA==
X-ME-Sender: <xms:OF7_Xx6JrDfSLond4SdijQW1IMz99pgfB2Y-jQhFRZGLE6vlleXj4w>
<xme:OF7_XzNB58AexdkUren-kgz8zw9NW9e8zeedwhCsHzmYxb0v0Mr0FL9rrQIJQuOXZ
Uicr1vemmI6eGXu3w>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedukedrtdefgddugeduucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu
ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf
hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl
ohhnrdhnvght
X-ME-Proxy: <xmx:OF7_X3lHoxdaj-_fn0Qnvl6PfC--Ef0Ir20O0pYDOXzF7Y5lzej53A>
<xmx:OF7_XyQcGkY_zxdxT_IdI_Fr7HusrTLKuN7RzxBBpcNvuSOxGYJf3A>
<xmx:OF7_X7BbFKw3gpDWxa1iKueUkume0kSCFu3g6zSnrpT3xMf--V_mJA>
<xmx:OF7_XzwGYZTwplYauVfIJlk0ZoUqf0raSZqVcSHzG7sf19B1IQj9KA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id DD779108005C;
Wed, 13 Jan 2021 15:55:15 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, stable@dpdk.org, Olivier Matz <olivier.matz@6wind.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Ranjit Menon <ranjit.menon@intel.com>, Aaron <aconole@redhat.com>
Date: Wed, 13 Jan 2021 21:55:12 +0100
Message-ID: <1999240.RY27NfppNA@thomas>
In-Reply-To: <abda0119-628e-8874-d7ff-abc57265c0a8@intel.com>
References: <20210112003602.29004-1-dmitry.kozliuk@gmail.com>
<abda0119-628e-8874-d7ff-abc57265c0a8@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] build: fix using ELF-only
linker flags with COFF
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
13/01/2021 21:27, Ranjit Menon:
> On 1/11/2021 4:36 PM, Dmitry Kozlyuk wrote:
> > The --export-dynamic linker option is only applicable to ELF.
> > On Windows, where COFF is used, it causes warnings:
> >
> > x86_64-w64-mingw32-ld: warning: --export-dynamic is not supported
> > for PE+ targets, did you mean --export-all-symbols? (MinGW)
> >
> > LINK : warning LNK4044: unrecognized option '/-export-dynamic';
> > ignored (clang)
> >
> > Don't add --export-dynamic on Windows anywhere.
> >
> > Fixes: b031e13d7f0d ("build: fix plugin load on static build")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> > ---
> > Using TLS variables with DLLs is problematic on Windows for now,
> > so not attempting to check or solve the issue with plugin load.
>
> Acked-by: Ranjit Menon <ranjit.menon@intel.com>
Applied, thanks
Why we didn't catch it in advance in CI?