From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Min Hu (Connor)" <humin29@huawei.com>, dev@dpdk.org
Cc: Aaron Conole <aconole@redhat.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
David Marchand <david.marchand@redhat.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH 2/6] net/hns3: fix compiling error for using SVE algorithm
Date: Wed, 31 Mar 2021 10:14:06 +0100 [thread overview]
Message-ID: <199b2d8e-8683-ff34-4ea1-f4925b29512a@intel.com> (raw)
In-Reply-To: <d9505770-62d5-785c-3645-db416ec16c2f@huawei.com>
On 3/31/2021 1:55 AM, Min Hu (Connor) wrote:
>
>
> 在 2021/3/30 0:10, Ferruh Yigit 写道:
>> On 3/23/2021 1:45 PM, Min Hu (Connor) wrote:
>>> From: Huisong Li <lihuisong@huawei.com>
>>>
>>> The 'queue_full_cnt' stats have been encapsulated in 'dfx_stats'.
>>> However, the modification in the SVE algorithm is omitted.
>>> As a result, the driver fails to be compiled when the SVE
>>> algorithm is used.
>>>
>>> Fixes: 9b77f1fe303f ("net/hns3: encapsulate DFX stats in datapath")
>>>
>>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>>> ---
>>> drivers/net/hns3/hns3_rxtx_vec_sve.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/hns3/hns3_rxtx_vec_sve.c
>>> b/drivers/net/hns3/hns3_rxtx_vec_sve.c
>>> index f8655fa..e1a1731 100644
>>> --- a/drivers/net/hns3/hns3_rxtx_vec_sve.c
>>> +++ b/drivers/net/hns3/hns3_rxtx_vec_sve.c
>>> @@ -439,7 +439,7 @@ hns3_xmit_fixed_burst_vec_sve(void *__restrict tx_queue,
>>> nb_pkts = RTE_MIN(txq->tx_bd_ready, nb_pkts);
>>> if (unlikely(nb_pkts == 0)) {
>>> - txq->queue_full_cnt++;
>>> + txq->dfx_stats.queue_full_cnt++;
>>> return 0;
>>> }
>>>
>>
>> Hi Connor,
>>
>> This is a very obvious build error, I am concerned how this is released. Do
>> you have any internal testing?
>>
> Hi Ferruh,
> Well, we admit it is our mistake for this issue. Let me
> describe the reason:
> Firstly, we must declare that we have our inner CI system for
> building and testing. While when we upstream the ""support SVE" patch,
> our CI does not support SVE building. Instead we build and test SVE on
> our local platform.
> Then when we upstream the "encapsulate DFX stats in datapath"
> patch, we only build it in CI(at that time, SVE building is still not
> supported), regardless of SVE building on local platform.
> Now, SVE building is supported in our CI, So the building error
> occurs.
> We'll pay more attention to the issue in the future. Thanks.
>
Good to hear your internal testing covers SVE now, thanks for clarification.
next prev parent reply other threads:[~2021-03-31 9:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 13:45 [dpdk-dev] [PATCH 0/6] bugfixes for hns3 Min Hu (Connor)
2021-03-23 13:45 ` [dpdk-dev] [PATCH 1/6] net/hns3: fix the reporting of undefined speed Min Hu (Connor)
2021-03-23 13:45 ` [dpdk-dev] [PATCH 2/6] net/hns3: fix compiling error for using SVE algorithm Min Hu (Connor)
2021-03-29 16:10 ` Ferruh Yigit
2021-03-29 18:31 ` Aaron Conole
2021-03-29 19:42 ` David Marchand
2021-03-29 22:13 ` Honnappa Nagarahalli
2021-03-31 0:55 ` Min Hu (Connor)
2021-03-31 9:14 ` Ferruh Yigit [this message]
2021-03-23 13:45 ` [dpdk-dev] [PATCH 3/6] net/hns3: fix TCP SEG and TCP CKSUM flag set Min Hu (Connor)
2021-03-23 13:45 ` [dpdk-dev] [PATCH 4/6] net/hns3: fix Tx checksum for UDP packets with special port Min Hu (Connor)
2021-03-23 13:45 ` [dpdk-dev] [PATCH 5/6] net/hns3: fix link update when failed to get link info Min Hu (Connor)
2021-03-23 13:45 ` [dpdk-dev] [PATCH 6/6] net/hns3: fix the long taskqueue pairs reset time Min Hu (Connor)
2021-03-30 10:35 ` [dpdk-dev] [PATCH 0/6] bugfixes for hns3 Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199b2d8e-8683-ff34-4ea1-f4925b29512a@intel.com \
--to=ferruh.yigit@intel.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=aconole@redhat.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=humin29@huawei.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).