From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CDB0BA034F; Wed, 31 Mar 2021 11:14:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 51A594069E; Wed, 31 Mar 2021 11:14:36 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 8B06640141 for ; Wed, 31 Mar 2021 11:14:34 +0200 (CEST) IronPort-SDR: F7vGLpjzmTgp8omwmv8sYZjbf7VRU8jqZtT4/vTFEY7609zhNOVKtt1dSHMcyVwlGhzLd4Y4xr 4RGFE3UOJukA== X-IronPort-AV: E=McAfee;i="6000,8403,9939"; a="171373324" X-IronPort-AV: E=Sophos;i="5.81,293,1610438400"; d="scan'208";a="171373324" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2021 02:14:11 -0700 IronPort-SDR: O4rldP9dOwuuevngAZg1kzA1ZdzIRbw12hE1FxR4zV8Zg6Qar3Fdz8aD4JaNBge4yXETHVbV9Z mGhmCuuRQhpA== X-IronPort-AV: E=Sophos;i="5.81,293,1610438400"; d="scan'208";a="445590166" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.249.9]) ([10.213.249.9]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2021 02:14:10 -0700 To: "Min Hu (Connor)" , dev@dpdk.org Cc: Aaron Conole , Honnappa Nagarahalli , David Marchand , Thomas Monjalon References: <1616507156-35880-1-git-send-email-humin29@huawei.com> <1616507156-35880-3-git-send-email-humin29@huawei.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <199b2d8e-8683-ff34-4ea1-f4925b29512a@intel.com> Date: Wed, 31 Mar 2021 10:14:06 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 2/6] net/hns3: fix compiling error for using SVE algorithm X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/31/2021 1:55 AM, Min Hu (Connor) wrote: > > > 在 2021/3/30 0:10, Ferruh Yigit 写道: >> On 3/23/2021 1:45 PM, Min Hu (Connor) wrote: >>> From: Huisong Li >>> >>> The 'queue_full_cnt' stats have been encapsulated in 'dfx_stats'. >>> However, the modification in the SVE algorithm is omitted. >>> As a result, the driver fails to be compiled when the SVE >>> algorithm is used. >>> >>> Fixes: 9b77f1fe303f ("net/hns3: encapsulate DFX stats in datapath") >>> >>> Signed-off-by: Huisong Li >>> Signed-off-by: Min Hu (Connor) >>> --- >>>   drivers/net/hns3/hns3_rxtx_vec_sve.c | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/net/hns3/hns3_rxtx_vec_sve.c >>> b/drivers/net/hns3/hns3_rxtx_vec_sve.c >>> index f8655fa..e1a1731 100644 >>> --- a/drivers/net/hns3/hns3_rxtx_vec_sve.c >>> +++ b/drivers/net/hns3/hns3_rxtx_vec_sve.c >>> @@ -439,7 +439,7 @@ hns3_xmit_fixed_burst_vec_sve(void *__restrict tx_queue, >>>       nb_pkts = RTE_MIN(txq->tx_bd_ready, nb_pkts); >>>       if (unlikely(nb_pkts == 0)) { >>> -        txq->queue_full_cnt++; >>> +        txq->dfx_stats.queue_full_cnt++; >>>           return 0; >>>       } >>> >> >> Hi Connor, >> >> This is a very obvious build error, I am concerned how this is released. Do >> you have any internal testing? >> > Hi Ferruh, >     Well, we admit it is our mistake for this issue. Let me > describe the reason: >     Firstly, we must declare that we have our inner CI system for > building and testing. While when we upstream the ""support SVE" patch, > our CI does not support SVE building. Instead we build and test SVE on > our local platform. >     Then when we upstream the "encapsulate DFX stats in datapath" > patch, we only build it in CI(at that time, SVE building is still not > supported), regardless of SVE building on local platform. >     Now, SVE building is supported in our CI， So the building error > occurs. >     We'll pay more attention to the issue in the future. Thanks. > Good to hear your internal testing covers SVE now, thanks for clarification.