From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 07DBB2BC7 for ; Thu, 29 Mar 2018 14:06:23 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8E4F04023150; Thu, 29 Mar 2018 12:06:21 +0000 (UTC) Received: from [10.36.112.54] (ovpn-112-54.ams2.redhat.com [10.36.112.54]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 193A4100F2EE; Thu, 29 Mar 2018 12:06:19 +0000 (UTC) To: zhiyong.yang@intel.com, dev@dpdk.org Cc: jianfeng.tan@intel.com, zhihong.wang@intel.com, thomas@monjalon.net, dong1.wang@intel.com, tiwei.bie@intel.com References: <20180214145330.4679-1-zhiyong.yang@intel.com> <20180321030343.64399-1-zhiyong.yang@intel.com> <20180321030343.64399-3-zhiyong.yang@intel.com> From: Maxime Coquelin Message-ID: <19b2c5ce-0905-3d59-6e1f-2b810627bf47@redhat.com> Date: Thu, 29 Mar 2018 14:06:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180321030343.64399-3-zhiyong.yang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Thu, 29 Mar 2018 12:06:21 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Thu, 29 Mar 2018 12:06:21 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v3 2/4] net/virtio: add checking for cvq X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2018 12:06:25 -0000 On 03/21/2018 04:03 AM, zhiyong.yang@intel.com wrote: > Add checking for cvq to judge if virtio_ack_link_announce should be called. > The existing code doesn't cause issue, and add the checking just to look > more reasonable. > > Signed-off-by: Zhiyong Yang > --- > drivers/net/virtio/virtio_ethdev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > index f377d8aa3..b567d3cf8 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -1337,7 +1337,8 @@ virtio_interrupt_handler(void *param) > > if (isr & VIRTIO_NET_S_ANNOUNCE) { > virtio_notify_peers(dev); > - virtio_ack_link_announce(dev); > + if (hw->cvq) > + virtio_ack_link_announce(dev); > } > } > > Applied to dpdk-next-virtio/master. Thanks, Maxime