From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dharton@cisco.com> Received: from rcdn-iport-5.cisco.com (rcdn-iport-5.cisco.com [173.37.86.76]) by dpdk.org (Postfix) with ESMTP id 4886F2BBC for <dev@dpdk.org>; Mon, 6 Jun 2016 14:45:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=3038; q=dns/txt; s=iport; t=1465217131; x=1466426731; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=3GkoEUV9W0gohNaCHn1lrfegok/sxlSeuaB8SqTEgNE=; b=OB2uDrFiZ9N9Vugyalf0J83YOY7j5AFFnUOWBxLPVh28XGgHkTTm7fAb g7gNe4uC72BugHen65Lad3lZkvFSCLmzi0Ukm3wwdsYzfP9rR7DaTZ8o0 LoQm+C5sVaW1kcd5IPa9J8j0XWdMgqfHqNug4hzpKlLOX7ul3ILtab6Yb o=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0D/AQCjb1VX/4oNJK1bgzqBUwa4RIIPg?= =?us-ascii?q?XqGEgKBMzgUAQEBAQEBAWUnhEUBAQEEOksEAgEIEQQBAR8JBzIUCQgCBAESCIg?= =?us-ascii?q?nunIBAQEBAQEBAQEBAQEBAQEBAQEBAQEchieETYoaBY1mimIBjh6BcI01hjuJH?= =?us-ascii?q?gEeNoNubgGJGX8BAQE?= X-IronPort-AV: E=Sophos;i="5.26,427,1459814400"; d="scan'208";a="112187207" Received: from alln-core-5.cisco.com ([173.36.13.138]) by rcdn-iport-5.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 06 Jun 2016 12:45:29 +0000 Received: from XCH-RCD-017.cisco.com (xch-rcd-017.cisco.com [173.37.102.27]) by alln-core-5.cisco.com (8.14.5/8.14.5) with ESMTP id u56CjTFf028691 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 6 Jun 2016 12:45:29 GMT Received: from xch-rcd-016.cisco.com (173.37.102.26) by XCH-RCD-017.cisco.com (173.37.102.27) with Microsoft SMTP Server (TLS) id 15.0.1104.5; Mon, 6 Jun 2016 07:45:28 -0500 Received: from xch-rcd-016.cisco.com ([173.37.102.26]) by XCH-RCD-016.cisco.com ([173.37.102.26]) with mapi id 15.00.1104.009; Mon, 6 Jun 2016 07:45:28 -0500 From: "David Harton (dharton)" <dharton@cisco.com> To: Remy Horton <remy.horton@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "Thomas Monjalon" <thomas.monjalon@6wind.com>, Helin Zhang <helin.zhang@intel.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>, Jing Chen <jing.d.chen@intel.com>, "Huawei Xie" <huawei.xie@intel.com> Thread-Topic: [dpdk-dev] [PATCH v3 00/10] Remove string operations from xstats Thread-Index: AQHRumDJL7ov9qOa80eBuPT8HsyA65/cbcwg Date: Mon, 6 Jun 2016 12:45:28 +0000 Message-ID: <19be2fcc78e94697ba60ad5ee39d27af@XCH-RCD-016.cisco.com> References: <1462533074-1994-1-git-send-email-remy.horton@intel.com> <1464605292-4599-1-git-send-email-remy.horton@intel.com> In-Reply-To: <1464605292-4599-1-git-send-email-remy.horton@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.82.226.45] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 00/10] Remove string operations from xstats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 06 Jun 2016 12:45:31 -0000 Acked-by: David Harton <dharton@cisco.com> > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Remy Horton > Sent: Monday, May 30, 2016 6:48 AM > To: dev@dpdk.org; Thomas Monjalon <thomas.monjalon@6wind.com>; Helin Zhan= g > <helin.zhang@intel.com>; Wenzhuo Lu <wenzhuo.lu@intel.com>; Jing Chen > <jing.d.chen@intel.com>; Huawei Xie <huawei.xie@intel.com> > Subject: [dpdk-dev] [PATCH v3 00/10] Remove string operations from xstats >=20 > The current extended ethernet statistics fetching involve doing several > string operations, which causes performance issues if there are lots of > statistics and/or network interfaces. This patchset changes the API for > xstats to use integer identifiers instead of strings and implements > this new API for the ixgbe, i40e, e1000, fm10k, and virtio drivers. >=20 > -- >=20 > v3 changes: > * Corrected ixgbe vf xstats fetching > * Added xstats changes to e1000, f10k, and virtio drivers > * Added cleanup patch that removes now-redundant name field > * Removed ethtool xstats command > * Removed unused .xstats_count from eth-dev_ops > * Changed test-pmd & proc_info to use new API > * Added documentation update > * Added missing changes to .map file (affected shared lib builds) >=20 > v2 changes: > * Fetching xstats count now seperate API function > * Added #define constants for some magic numbers > * Fixed bug with virtual function count fetching > * For non-xstats-supporting drivers, queue stats returned > * Some refactoring/cleanups > * Removed index assumption from example >=20 > Remy Horton (10): > rte: change xstats to use integer ids > drivers/net/ixgbe: change xstats to use integer ids > drivers/net/e1000: change xstats to use integer ids > drivers/net/fm10k: change xstats to use integer ids > drivers/net/i40e: change xstats to use integer ids > drivers/net/virtio: change xstats to use integer ids > app/test-pmd: change xstats to use integer ids > app/proc_info: change xstats to use integer ids > remove name field from struct rte_eth_xstats > doc: update xstats documentation >=20 > app/proc_info/main.c | 26 ++++++++- > app/test-pmd/config.c | 52 +++++++++++++---- > doc/guides/prog_guide/poll_mode_drv.rst | 25 +++++++-- > drivers/net/e1000/igb_ethdev.c | 50 +++++++++++++++-- > drivers/net/fm10k/fm10k_ethdev.c | 52 ++++++++++++++--- > drivers/net/i40e/i40e_ethdev.c | 77 +++++++++++++++++++++----- > drivers/net/i40e/i40e_ethdev_vf.c | 24 +++++++- > drivers/net/ixgbe/ixgbe_ethdev.c | 98 > ++++++++++++++++++++++++++++----- > drivers/net/virtio/virtio_ethdev.c | 60 +++++++++++++++++--- > lib/librte_ether/rte_ethdev.c | 92 > ++++++++++++++++++++++++++++--- > lib/librte_ether/rte_ethdev.h | 44 ++++++++++++++- > lib/librte_ether/rte_ether_version.map | 7 +++ > 12 files changed, 527 insertions(+), 80 deletions(-) >=20 > -- > 2.5.5