From: "Wei Hu (Xavier)" <xavier.huwei@huawei.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
"Wei Hu (Xavier)" <xavier.huwei@tom.com>, <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/4] net/hns3: modify the statistics for sending and receiving messages
Date: Fri, 18 Oct 2019 16:23:17 +0800 [thread overview]
Message-ID: <19c1373f-5d29-b89e-08c7-6884bac83fd5@huawei.com> (raw)
In-Reply-To: <31868759-1900-2aad-4e38-0ae8fe52647a@intel.com>
Hi, Ferruh Yigit
On 2019/10/15 16:45, Ferruh Yigit wrote:
> On 10/9/2019 3:16 PM, Wei Hu (Xavier) wrote:
>> From: Hao Chen <chenhao164@huawei.com>
>>
>> In receiving direction, for FCS error messages, drivers no longer
>> record them in rte_eth_stats.ipackets statistics.
> If this patch is fixing statistics better to convert commit log into a fix patch
> with Fixes tags etc. This helps for your patches has been backported to LTS.
> Same for other patches in the set.
>
>> In sending direction, for messages of illegal length, too long or
>> equals 0, drivers will not notify the network card hardware to
>> send them, will not continue to send the remaining message in burst,
>> and will not record them in rte_eth_stats.opackets statistics.
>>
>> Signed-off-by: Hao Chen <chenhao164@huawei.com>
>> Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
> <...>
>
>> @@ -979,6 +976,7 @@ hns3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
>> first_seg->pkt_len = pkt_len;
>> first_seg->port = rxq->port_id;
>> first_seg->hash.rss = rte_le_to_cpu_32(rxdp->rx.rss_hash);
>> + first_seg->ol_flags |= PKT_RX_RSS_HASH;
> This is unrelated change for this patch, can you please extract into its own patch?
>
We will fix them and send patch V2.
Thanks for your comment.
Regards
Xavier
next prev parent reply other threads:[~2019-10-18 8:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 14:16 [dpdk-dev] [PATCH 0/4] updates for hns3 ethernet pmd driver Wei Hu (Xavier)
2019-10-09 14:16 ` [dpdk-dev] [PATCH 1/4] net/hns3: modify the statistics for sending and receiving messages Wei Hu (Xavier)
2019-10-15 8:45 ` Ferruh Yigit
2019-10-18 8:23 ` Wei Hu (Xavier) [this message]
2019-10-09 14:16 ` [dpdk-dev] [PATCH 2/4] net/hns3: change the return value of firmware processing timeout from -EBADE to -ETIME Wei Hu (Xavier)
2019-10-09 14:16 ` [dpdk-dev] [PATCH 3/4] net/hns3: Renew command and desc structure Wei Hu (Xavier)
2019-10-15 8:45 ` Ferruh Yigit
2019-10-25 12:34 ` Wei Hu (Xavier)
2019-10-09 14:16 ` [dpdk-dev] [PATCH 4/4] net/hns3: restores bus_master_en and msix_enable during PF FLR reset Wei Hu (Xavier)
2019-10-10 3:28 ` [dpdk-dev] [PATCH 0/4] updates for hns3 ethernet pmd driver Wei Hu (Xavier)
2019-10-15 8:46 ` Ferruh Yigit
2019-10-18 8:24 ` Wei Hu (Xavier)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19c1373f-5d29-b89e-08c7-6884bac83fd5@huawei.com \
--to=xavier.huwei@huawei.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=xavier.huwei@tom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).