From: "Tahhan, Maryam" <maryam.tahhan@intel.com>
To: "dev@dpdk.org" <dev@dpdk.org>, Olivier MATZ <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v3 0/7] Expose IXGBE extended stats to DPDK apps
Date: Wed, 1 Jul 2015 14:27:14 +0000 [thread overview]
Message-ID: <1A27633A6DA49C4A92FCD5D4312DBF536A456AC0@IRSMSX109.ger.corp.intel.com> (raw)
In-Reply-To: <1435323558-169985-1-git-send-email-maryam.tahhan@intel.com>
> This patch set implements xstats_get() and xstats_reset() in dev_ops for ixgbe
> to expose detailed error statistics to DPDK applications. The dump_cfg
> application was extended to demonstrate the usage of retrieving statistics for
> DPDK interfaces and renamed to proc_info in order reflect this new
> functionality. This patch set also removes non generic statistics from the
> statistics strings at the ethdev level and marks the relevant registers as
> depricated in struct rte_eth_stats.
>
> v2:
> - Fixed patch dependencies.
> - Broke down patches into smaller logical changes.
>
> v3:
> - Removes non-generic stats fields in rte_stats_strings and deprecates
> the fields related to them in struct rte_eth_stats.
> - Modifies rte_eth_xstats_get() to return generic stats and extended stats.
>
> Maryam Tahhan (7):
> ixgbe: move stats register reads to a new function
> ixgbe: add functions to get and reset xstats
> ethdev: expose extended error stats
> ethdev: remove HW specific stats in stats structs
> ixgbe: add NIC specific stats removed from ethdev
> app: remove dump_cfg
> app: add a new app proc_info
>
> MAINTAINERS | 4 +
> app/Makefile | 2 +-
> app/dump_cfg/Makefile | 45 ----
> app/dump_cfg/main.c | 92 -------
> app/proc_info/Makefile | 45 ++++
> app/proc_info/main.c | 512
> +++++++++++++++++++++++++++++++++++++++
> doc/guides/rel_notes/abi.rst | 11 +
> drivers/net/ixgbe/ixgbe_ethdev.c | 192 ++++++++++++---
> lib/librte_ether/rte_ethdev.c | 29 ++-
> lib/librte_ether/rte_ethdev.h | 30 ++-
> mk/rte.sdktest.mk | 4 +-
> 11 files changed, 762 insertions(+), 204 deletions(-) delete mode 100644
> app/dump_cfg/Makefile delete mode 100644 app/dump_cfg/main.c create
> mode 100644 app/proc_info/Makefile create mode 100644
> app/proc_info/main.c
>
> --
> 1.9.3
Hi Olivier,
I posted a new patch set with the suggested mods. Let me know if there are any issues.
Thanks in advance.
Best Regards,
Maryam
prev parent reply other threads:[~2015-07-01 14:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 12:59 Maryam Tahhan
2015-06-26 12:59 ` [dpdk-dev] [PATCH v3 1/7] ixgbe: move stats register reads to a new function Maryam Tahhan
2015-06-26 12:59 ` [dpdk-dev] [PATCH v3 2/7] ixgbe: add functions to get and reset xstats Maryam Tahhan
2015-07-03 13:16 ` Olivier MATZ
2015-07-03 13:19 ` Olivier MATZ
2015-07-05 9:34 ` Tahhan, Maryam
2015-07-05 10:02 ` Tahhan, Maryam
2015-07-05 9:27 ` Tahhan, Maryam
2015-06-26 12:59 ` [dpdk-dev] [PATCH v3 3/7] ethdev: expose extended error stats Maryam Tahhan
2015-07-03 13:27 ` Olivier MATZ
2015-06-26 12:59 ` [dpdk-dev] [PATCH v3 4/7] ethdev: remove HW specific stats in stats structs Maryam Tahhan
2015-06-26 14:03 ` Kyle Larose
2015-06-26 14:30 ` Tahhan, Maryam
2015-06-26 14:37 ` Kyle Larose
2015-06-26 14:47 ` Tahhan, Maryam
2015-06-26 12:59 ` [dpdk-dev] [PATCH v3 5/7] ixgbe: add NIC specific stats removed from ethdev Maryam Tahhan
2015-06-26 12:59 ` [dpdk-dev] [PATCH v3 6/7] app: remove dump_cfg Maryam Tahhan
2015-06-26 12:59 ` [dpdk-dev] [PATCH v3 7/7] app: add a new app proc_info Maryam Tahhan
2015-07-01 14:27 ` Tahhan, Maryam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1A27633A6DA49C4A92FCD5D4312DBF536A456AC0@IRSMSX109.ger.corp.intel.com \
--to=maryam.tahhan@intel.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).