From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 95A8A2C7A for ; Mon, 13 Jul 2015 15:30:39 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 13 Jul 2015 06:30:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,462,1432623600"; d="scan'208";a="523435644" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by FMSMGA003.fm.intel.com with ESMTP; 13 Jul 2015 06:30:37 -0700 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.200]) by IRSMSX106.ger.corp.intel.com ([169.254.8.121]) with mapi id 14.03.0224.002; Mon, 13 Jul 2015 14:30:36 +0100 From: "Tahhan, Maryam" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v4 8/8] app: add a new app proc_info Thread-Index: AQHQt0mvn9fcW7vARE6hgpKJJUXp553SUOGAgAcGPqA= Date: Mon, 13 Jul 2015 13:30:36 +0000 Message-ID: <1A27633A6DA49C4A92FCD5D4312DBF536A463B65@IRSMSX109.ger.corp.intel.com> References: <1436118000-132275-1-git-send-email-maryam.tahhan@intel.com> <1436118000-132275-9-git-send-email-maryam.tahhan@intel.com> <3280448.8fAfYn9D23@xps13> In-Reply-To: <3280448.8fAfYn9D23@xps13> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v4 8/8] app: add a new app proc_info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jul 2015 13:30:40 -0000 > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Thursday, July 9, 2015 2:40 AM > To: Tahhan, Maryam > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 8/8] app: add a new app proc_info >=20 > 2015-07-05 18:40, Maryam Tahhan: > > proc_info displays statistics information including extened stats for >=20 > typo: extended >=20 > > given DPDK ports and dumps the memory information for DPDK. > > > > Signed-off-by: Maryam Tahhan > > --- > > MAINTAINERS | 4 + > > app/Makefile | 1 + > > app/proc_info/Makefile | 45 +++++ > > app/proc_info/main.c | 512 > +++++++++++++++++++++++++++++++++++++++++++++++++ > > mk/rte.sdktest.mk | 4 +- > > 5 files changed, 564 insertions(+), 2 deletions(-) >=20 > A doc would be useful. I will add a doc >=20 > > +DIRS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) +=3D proc_info >=20 > Why only Linux? Dump_cfg was only supported on Linux also, I've only tested it on Linux. >=20 > > +# Copyright(c) 2010-2014 Intel Corporation. All rights reserved. >=20 > Too old :) >=20 > > + if ((!port->rx_queue_stats_mapping_enabled) && (!port- > >tx_queue_stats_mapping_enabled)) { > > + printf(" RX-packets: %-10"PRIu64" RX-missed: %-10"PRIu64" > RX-bytes: " > > + "%-"PRIu64"\n", > > + stats.ipackets, stats.imissed, stats.ibytes); > > + printf(" RX-badcrc: %-10"PRIu64" RX-badlen: %-10"PRIu64" > RX-errors: " > > + "%-"PRIu64"\n", > > + stats.ibadcrc, stats.ibadlen, stats.ierrors); > > + printf(" RX-nombuf: %-10"PRIu64"\n", > > + stats.rx_nombuf); > > + printf(" TX-packets: %-10"PRIu64" TX-errors: %-10"PRIu64" > TX-bytes: " > > + "%-"PRIu64"\n", > > + stats.opackets, stats.oerrors, stats.obytes); > > + } else { > > + printf(" RX-packets: %10"PRIu64" RX-errors: > %10"PRIu64 > > + " RX-bytes: %10"PRIu64"\n", > > + stats.ipackets, stats.ierrors, stats.ibytes); > > + printf(" RX-badcrc: %10"PRIu64" RX-badlen: > %10"PRIu64 > > + " RX-errors: %10"PRIu64"\n", > > + stats.ibadcrc, stats.ibadlen, stats.ierrors); > > + printf(" RX-nombuf: %10"PRIu64"\n", > > + stats.rx_nombuf); > > + printf(" TX-packets: %10"PRIu64" TX-errors: > %10"PRIu64 > > + " TX-bytes: %10"PRIu64"\n", > > + stats.opackets, stats.oerrors, stats.obytes); > > + } >=20 > Why the formatting is different depending of device-specific stats mappin= g? I will update this and remove the deprecated stats from being printed as we= ll. >=20 > > + if (port->rx_queue_stats_mapping_enabled) { > > + printf("\n"); > > + for (i =3D 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS; i++) { > > + printf(" Stats reg %2d RX-packets: %10"PRIu64 > > + " RX-errors: %10"PRIu64 > > + " RX-bytes: %10"PRIu64"\n", > > + i, stats.q_ipackets[i], stats.q_errors[i], > stats.q_ibytes[i]); > > + } > > + } >=20 > Why restricting stats per queue to devices requiring a mapping? I will change this >=20 > > - $(RTE_OUTPUT)/app/dump_cfg --file-prefix=3Dring_perf ; \ >=20 > This should have been removed in previous patch. I will remove this in the previous patch