From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <maryam.tahhan@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id A4696C4DE
 for <dev@dpdk.org>; Thu, 30 Jul 2015 11:18:36 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by orsmga101.jf.intel.com with ESMTP; 30 Jul 2015 02:18:36 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.15,576,1432623600"; d="scan'208";a="758267543"
Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25])
 by fmsmga001.fm.intel.com with ESMTP; 30 Jul 2015 02:18:34 -0700
Received: from irsmsx109.ger.corp.intel.com ([169.254.13.130]) by
 irsmsx110.ger.corp.intel.com ([169.254.15.29]) with mapi id 14.03.0224.002;
 Thu, 30 Jul 2015 10:18:33 +0100
From: "Tahhan, Maryam" <maryam.tahhan@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH v1 1/1] ixgbe: Fix oerrors by setting it to 0
Thread-Index: AQHQyUtuCJd+ofVJ5kWHef7POQhXSJ3yEz8AgADzdQCAALdGQA==
Date: Thu, 30 Jul 2015 09:18:32 +0000
Message-ID: <1A27633A6DA49C4A92FCD5D4312DBF536A4B1005@IRSMSX109.ger.corp.intel.com>
References: <1438097889-151949-1-git-send-email-maryam.tahhan@intel.com>
 <2601191342CEEE43887BDE71AB97725836A69A41@irsmsx105.ger.corp.intel.com>
 <2349858.est3WNPp0t@xps13>
In-Reply-To: <2349858.est3WNPp0t@xps13>
Accept-Language: en-IE, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1 1/1] ixgbe: Fix oerrors by setting it to 0
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Jul 2015 09:18:37 -0000

> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Thursday, July 30, 2015 12:20 AM
> To: Tahhan, Maryam
> Cc: dev@dpdk.org; Ananyev, Konstantin
> Subject: Re: [dpdk-dev] [PATCH v1 1/1] ixgbe: Fix oerrors by setting it t=
o 0
>=20
> > > Fix afebc86be1346136125af8026dc215f81c202c50. oerrors was txdgpc -
> > > hw_stats->gptc, txdgpc is the number of packets DMA'ed by the host
> > > and was being reset on every call to read stats so it could be < gptc=
.
> > > Because we currently have no way to add txdgpc to struct hw_stats so
> > > that we can maintain a persistent value per port oerrors has now
> > > been set to 0. References to txdgpc is now removed as we don't use
> > > it. This patch also removes rxnfgpc as it's not used anywhere.
> > >
> > > Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
> > Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
>=20
> Applied, thanks
>=20
> It's a bit sad.
> Is it a consequence of forbidding updates in the base driver?

Yes, that's exactly it.

In the meantime I'm going to look at/investigate another way to allow us to=
 maintain additional (anything not in struct hw_stats) per port stats/regis=
ters in addition to the base driver.=20

All the best
Maryam