From: "Tahhan, Maryam" <maryam.tahhan@intel.com>
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] ixgbe: remove rx jabber from ierrors
Date: Tue, 20 Oct 2015 09:38:43 +0000 [thread overview]
Message-ID: <1A27633A6DA49C4A92FCD5D4312DBF536A5D308F@IRSMSX109.ger.corp.intel.com> (raw)
In-Reply-To: <1445332999-21774-1-git-send-email-harry.van.haaren@intel.com>
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Harry van Haaren
> Sent: Tuesday, October 20, 2015 10:23 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v3] ixgbe: remove rx jabber from ierrors
>
> Remove receive jabber count (rjc) from ierrors count as the register overlaps
> with the CRC error register, previously causing some packets to be counted
> twice.
>
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> ---
>
> v3: Add details about register overlap
> v2: Fix typo
>
> drivers/net/ixgbe/ixgbe_ethdev.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index ec2918c..6e20e06 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -2206,7 +2206,6 @@ ixgbe_dev_stats_get(struct rte_eth_dev *dev,
> struct rte_eth_stats *stats)
> hw_stats->mlfc +
> hw_stats->mrfc +
> hw_stats->rfc +
> - hw_stats->rjc +
> hw_stats->fccrc +
> hw_stats->fclast;
>
> --
> 1.9.1
Acked-by: Maryam Tahhan <maryam.tahhan@intel.com>
next prev parent reply other threads:[~2015-10-20 9:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20151014163553.GB7420@bricha3-MOBL3>
2015-10-14 17:12 ` [dpdk-dev] [PATCH v2] " Harry van Haaren
2015-10-20 1:13 ` Lu, Wenzhuo
2015-10-20 8:30 ` Van Haaren, Harry
2015-10-20 8:49 ` Lu, Wenzhuo
2015-10-20 9:23 ` [dpdk-dev] [PATCH v3] " Harry van Haaren
2015-10-20 9:38 ` Tahhan, Maryam [this message]
2015-10-21 0:54 ` Lu, Wenzhuo
2015-10-28 14:11 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1A27633A6DA49C4A92FCD5D4312DBF536A5D308F@IRSMSX109.ger.corp.intel.com \
--to=maryam.tahhan@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).