From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <maryam.tahhan@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 2982B8E91
 for <dev@dpdk.org>; Tue,  3 Nov 2015 14:14:54 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga101.fm.intel.com with ESMTP; 03 Nov 2015 05:14:54 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,238,1444719600"; d="scan'208";a="593175468"
Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157])
 by FMSMGA003.fm.intel.com with ESMTP; 03 Nov 2015 05:14:53 -0800
Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by
 IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Tue, 3 Nov 2015 13:14:52 +0000
Received: from irsmsx109.ger.corp.intel.com ([169.254.13.139]) by
 irsmsx112.ger.corp.intel.com ([169.254.1.218]) with mapi id 14.03.0248.002;
 Tue, 3 Nov 2015 13:14:52 +0000
From: "Tahhan, Maryam" <maryam.tahhan@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH v2 1/1] ethdev: distinguish between drop and
 error stats
Thread-Index: AQHRCmicEo5mUGdH+UKPLPinIcF7k56JfLOAgADhAmA=
Date: Tue, 3 Nov 2015 13:14:52 +0000
Message-ID: <1A27633A6DA49C4A92FCD5D4312DBF536A5E618C@IRSMSX109.ger.corp.intel.com>
References: <1445257253-3673-1-git-send-email-maryam.tahhan@intel.com>
 <3108772.cu7MlmvWl0@xps13>
In-Reply-To: <3108772.cu7MlmvWl0@xps13>
Accept-Language: en-IE, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/1] ethdev: distinguish between drop and
 error stats
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Nov 2015 13:14:55 -0000

> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Monday, November 2, 2015 11:47 PM
> To: Tahhan, Maryam <maryam.tahhan@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 1/1] ethdev: distinguish between drop a=
nd
> error stats
>=20
> 2015-10-19 13:20, Maryam Tahhan:
> > Make a distniction between dropped packets and error statistics to
> > allow a higher level fault management entity to interact with DPDK and
> > take appropriate measures when errors are detected. It will also
> > provide valuable information for any applications that
> > collects/extracts DPDK stats, such applications include Open vSwitch.
> > After this patch the distinction is:
> > ierrors =3D Total number of packets dropped by hardware (malformed
> > packets, ...) Where the # of drops can ONLY be <=3D  the packets
> > received (without overlap between registers).
> > ipkterrors =3D Total number of erroneous received packets. Where the #
> > of errors can be >=3D the packets received (without overlap between
> > registers), this is because there may be multiple errors associated
> > with a packet.
> [...]
> > -	uint64_t ierrors;   /**< Total number of erroneous received packets.
> */
> > +	uint64_t ierrors;
> > +	/**< Total number of packets dropped by hardware (malformed
> packets...)
> > +	 * Where the # of drops can ONLY be <=3D  the packets received
> (without
> > +	 * overlap between registers).
> > +	 */
> >  	uint64_t oerrors;   /**< Total number of failed transmitted packets. =
*/
> > +	uint64_t ipkterrors;
> > +	/**< Total number of erroneous received packets. Where the
> number of
> > +	 * errors can be >=3D the packets received (without overlap between
> > +	 * registers), this is because there may be multiple errors associate=
d
> with
> > +	 * a packet.
> > +	 */
>=20
> There was not a lot of comments on this proposal.
> If the idea is well received, it needs to be implemented in drivers, at l=
east few
> of them.

Hi Thomas
I was waiting to implement it across the drivers when I knew it was going t=
o be merged to master. It shouldn't break anything that's currently using e=
thdev stats and should be relatively straight forward to implement for the =
drivers. Does it makes sense to add it into drivers now or wait for the nex=
t open DPDK window?

Thanks
Maryam=20