From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id CA16429C7 for ; Mon, 10 Apr 2017 20:29:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1491848980; x=1523384980; h=from:to:subject:date:message-id:references:mime-version; bh=q9kwqjFmKGdPCrdhmSuMHJp4mxN6wPkc9aIoO3adhnI=; b=tofoMyUQ1bpkkeZvu/EOQtlVoqv8yEwikMUChfnttgiQr4qZw/SwIDD7 dut5jofn+j7sCc396Zk0r8DjgpDJyQ==; Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2017 11:29:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,182,1488873600"; d="scan'208,217";a="1117866523" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga001.jf.intel.com with ESMTP; 10 Apr 2017 11:29:39 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 10 Apr 2017 11:29:39 -0700 Received: from fmsmsx113.amr.corp.intel.com ([169.254.13.235]) by FMSMSX110.amr.corp.intel.com ([169.254.14.231]) with mapi id 14.03.0319.002; Mon, 10 Apr 2017 11:29:38 -0700 From: "Wiles, Keith" To: DPDK Thread-Topic: |WARNING| pw23442 [PATCH] net/tap: add support for fixed mac addresses Thread-Index: AQHSsicighxuQjmWJUquJ3Fxm8RdvQ== Date: Mon, 10 Apr 2017 18:29:38 +0000 Message-ID: <1B5FAA53-FFB2-44D4-8A08-3EEC17D3761E@intel.com> References: <20170410182018.918882C1A@dpdk.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.98.247] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: [dpdk-dev] Fwd: |WARNING| pw23442 [PATCH] net/tap: add support for fixed mac addresses X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Apr 2017 18:29:41 -0000 Begin forwarded message: From: > Subject: |WARNING| pw23442 [PATCH] net/tap: add support for fixed mac addre= sses Date: April 10, 2017 at 1:20:18 PM CDT To: > Cc: Keith Wiles > Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/23442 _coding style issues_ CHECK:BRACES: braces {} should be used on all arms of this statement #100: FILE: drivers/net/tap/rte_eth_tap.c:1242: + if (fixed_mac_type) { [...] + } else [...] CHECK:BRACES: Unbalanced braces around else statement #109: FILE: drivers/net/tap/rte_eth_tap.c:1251: + } else total: 0 errors, 0 warnings, 2 checks, 123 lines checked Got the above error running checkpatch locally then got the email above and= I assumed this warning can be ignored is this the case? Code that caused the warning: } else { if (fixed_mac_type) { static int iface_idx; pmd->eth_addr.addr_bytes[0] =3D 0x00; pmd->eth_addr.addr_bytes[1] =3D 'd'; pmd->eth_addr.addr_bytes[2] =3D 't'; pmd->eth_addr.addr_bytes[3] =3D 'a'; pmd->eth_addr.addr_bytes[4] =3D 'p'; pmd->eth_addr.addr_bytes[5] =3D 0 + iface_idx++; } else eth_random_addr((uint8_t *)&pmd->eth_addr); <<<<< } Regards, Keith