From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0085.outbound.protection.outlook.com [104.47.0.85]) by dpdk.org (Postfix) with ESMTP id 5CFE32BE1 for ; Fri, 30 Jun 2017 20:14:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=sG5wp/3QAvYt5o7i88CQmCI9F1BhWzk77jd79CrQhvM=; b=e/fTkOHFDTex7Wu5N2GIMG3d3erbWM6i8yLaXRvX4VhTdYzT3wI+7BVnKg7KQPOzCUMf57HnXhQoZz5Lbdv0jnIFSU8LUv1j0L9T2GNBiI/YOMUMw3JskywQs+xKOCUN0AkrD1vlPTKyhcAphdj5tPiz9nqwhAsxoRXPvNdFETo= Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com (10.167.195.147) by VI1PR0501MB2048.eurprd05.prod.outlook.com (10.167.195.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1220.11; Fri, 30 Jun 2017 18:14:57 +0000 Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::b9a4:d6b7:4f91:9418]) by VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::b9a4:d6b7:4f91:9418%14]) with mapi id 15.01.1220.014; Fri, 30 Jun 2017 18:14:56 +0000 From: Yongseok Koh To: Ferruh Yigit CC: Adrien Mazarguil , =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx: update C compliance standard Thread-Index: AQHS8cUKLTVA0CVfFUuVLZunWsypmqI9rkKAgAAHwIA= Date: Fri, 30 Jun 2017 18:14:56 +0000 Message-ID: <1C0F2AC4-AF9D-4A02-A35A-F70577FE67B5@mellanox.com> References: <4bc47a8c50dc528f8061d95cdd0c0934e4e40b38.1498843072.git.adrien.mazarguil@6wind.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0501MB2048; 7:JdEdVlDTvI1D8coLhcKc4glnuwGWfPWPBdonVQF72jxVs+h3cVWIpNW3XVHAQU669LTgRu0jRENf7i4069w9ixq8fBLjqR6s2WaYOcGyKXnzzafQ2DFwV3GU9cjXd6+E2tHsRDfqyBxszlcCwFfCSkTbiS4h7NaD/msGKHita9sCO3D7rkToAhm4Ra5Bolr7cBTHH+71paI8vtVPcYZav9I4Bcqkuy5LTpjLBp7365Hfeyri9yfoPElq8ONgm1AuiJ/e7FQ2oqlpA34+6czFLGNEQegoXLgNtIkedPDTEHZRPHajaw7QtRqyIzPWLGOG60jpVLpyd+8FjNdd00JO/yMurLEODl/HRM08Oum8vM2/sqYrIGfxtH9TeptD19qD2RvGg6gJ+WergJOE8z4oUeZ3NRsXgI1TpgoyrgvGDF9YjhHPX12jRccBuq1LhVQ/IxSNo7LsRFLqrWPyWZCr2MVFr5xBkDxR+ur++GPTjIrYMXbfc9+I5c8y5yBGZ7qDoCkVLZVHAnbpihzLDOyZ7GIYaj0NlXXC1qB+hZ9Hp022OvjevFPC8ZGQBqfzYjdP9HCGecRrgiVWR282l4ViYm8xG0nTawXh3rv2k87ePu/1S3Cs0Ort/n2DnN4wwNe1auRoD4jFiki95FBpBw0SdIIFDrw/pxa3UoS6Lnvt5/98OU4v5AxFM3yRYGfxAUI8LwY6uvcxUM3w2fpnZMWVSvJUUbx56CX1KqXPI7n7LTcKaow3AiWEEdF3iZae4v/T63DHP34LK3HK3MhnQAueqJiYPa2UR20xubw6gNR0XhE= x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-office365-filtering-correlation-id: da90c88a-c52a-4fe6-2474-08d4bfe3e9f1 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254075)(300000503095)(300135400095)(48565401081)(2017052603031)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:VI1PR0501MB2048; x-ms-traffictypediagnostic: VI1PR0501MB2048: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(133145235818549)(236129657087228)(167848164394848)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(6055026)(6041248)(20161123562025)(20161123560025)(20161123558100)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:VI1PR0501MB2048; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:VI1PR0501MB2048; x-forefront-prvs: 0354B4BED2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(39410400002)(39400400002)(39850400002)(39840400002)(24454002)(377454003)(3846002)(8676002)(50986999)(2900100001)(76176999)(81166006)(5660300001)(110136004)(7736002)(66066001)(36756003)(8936002)(54356999)(83716003)(53936002)(102836003)(6116002)(86362001)(2906002)(6486002)(6436002)(6506006)(478600001)(3280700002)(38730400002)(3660700001)(33656002)(6512007)(14454004)(6246003)(4326008)(25786009)(54906002)(99286003)(305945005)(53546010)(189998001)(5250100002)(82746002)(6916009)(2950100002)(229853002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2048; H:VI1PR0501MB2045.eurprd05.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-ID: <19D62EE4AB761440B2FE2D6F054A6B7E@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jun 2017 18:14:56.5396 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2048 Subject: Re: [dpdk-dev] [PATCH] net/mlx: update C compliance standard X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jun 2017 18:14:58 -0000 > On Jun 30, 2017, at 10:47 AM, Ferruh Yigit wrote= : >=20 > On 6/30/2017 6:19 PM, Adrien Mazarguil wrote: >> This commit addresses a compilation issue against Glibc >=3D 2.25, which >> implements assert() through a nonstandard ({ }) construct. Such construc= ts >> can normally not be used without __extension__ keyword when -pedantic is >> enabled, as is the case when compiling mlx4 and mlx5 PMDs in debug mode. >>=20 >> While assert.h checks for the compiler ability to support GNU extensions= , >> Clang, unlike GCC, does not allow the above syntax when combining >> -std=3Dgnu99 with -pedantic. >>=20 >> Work around missing keyword by moving these PMDs to a stricter complianc= e >> standard without GNU extensions but properly checked by Glibc. Doing so = is >> supported on the DPDK side since includes have been cleaned up. >>=20 >> Signed-off-by: Adrien Mazarguil >=20 > Applied to dpdk-next-net/master, thanks. This breaks debug-enabled build of mlx5 as mlx5 isn't ready yet! Thanks, Yongseok