From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id EAB6B1B1C9 for ; Tue, 15 May 2018 00:27:17 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 May 2018 15:27:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,402,1520924400"; d="scan'208";a="46220542" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga002.fm.intel.com with ESMTP; 14 May 2018 15:27:16 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 14 May 2018 15:27:16 -0700 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.235]) by FMSMSX110.amr.corp.intel.com ([169.254.14.122]) with mapi id 14.03.0319.002; Mon, 14 May 2018 15:27:16 -0700 From: "Wiles, Keith" To: "Varghese, Vipin" CC: "dev@dpdk.org" , "ophirmu@mellanox.com" , "Yigit, Ferruh" Thread-Topic: [dpdk-dev] [PATCH] net/tap: perform proto field update for tun only Thread-Index: AQHT6z+Mn9UXuF91TUWNUbV20DeFjqQwREEA Date: Mon, 14 May 2018 22:27:15 +0000 Message-ID: <1C489DFF-0DA4-4A5E-8E91-E0EA6171811D@intel.com> References: <1526273615-154067-1-git-send-email-vipin.varghese@intel.com> In-Reply-To: <1526273615-154067-1-git-send-email-vipin.varghese@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.16.78] Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/tap: perform proto field update for tun only X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 May 2018 22:27:18 -0000 DQoNCj4gT24gTWF5IDEzLCAyMDE4LCBhdCAxMTo1MyBQTSwgVmlwaW4gVmFyZ2hlc2UgPHZpcGlu LnZhcmdoZXNlQGludGVsLmNvbT4gd3JvdGU6DQo+IA0KPiBUaGUgVFggZnVuY3Rpb24gaXMgc2hh cmVkIGJldHdlZW4gVEFQIGFuZCBUVU4gUE1ELiBDaGVja2luZyBUVU4tVEFQDQo+IHR5cGUgZmll bGQgd2lsbCBlbnN1cmUgdGhlIFRBUCBQTUQgd2lsbCBhbHdheXMgaGF2ZSBwcm90b2NvbCBmaWVs ZCBhcyAwLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogVmlwaW4gVmFyZ2hlc2UgPHZpcGluLnZhcmdo ZXNlQGludGVsLmNvbT4NCj4gLS0tDQo+IGRyaXZlcnMvbmV0L3RhcC9ydGVfZXRoX3RhcC5jIHwg NTAgKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLQ0KPiBkcml2ZXJz L25ldC90YXAvcnRlX2V0aF90YXAuaCB8IDEwICsrKysrKysrKw0KPiAyIGZpbGVzIGNoYW5nZWQs IDQxIGluc2VydGlvbnMoKyksIDE5IGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvbmV0L3RhcC9ydGVfZXRoX3RhcC5jIGIvZHJpdmVycy9uZXQvdGFwL3J0ZV9ldGhfdGFw LmMNCj4gaW5kZXggZWE2ZDg5OS4uOThhYzNiNSAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9uZXQv dGFwL3J0ZV9ldGhfdGFwLmMNCj4gKysrIGIvZHJpdmVycy9uZXQvdGFwL3J0ZV9ldGhfdGFwLmMN Cj4gQEAgLTExNSw3ICsxMTUsOCBAQCB0dW5fYWxsb2Moc3RydWN0IHBtZF9pbnRlcm5hbHMgKnBt ZCkNCj4gCSAqIERvIG5vdCBzZXQgSUZGX05PX1BJIGFzIHBhY2tldCBpbmZvcm1hdGlvbiBoZWFk ZXIgd2lsbCBiZSBuZWVkZWQNCj4gCSAqIHRvIGNoZWNrIGlmIGEgcmVjZWl2ZWQgcGFja2V0IGhh cyBiZWVuIHRydW5jYXRlZC4NCj4gCSAqLw0KPiAtCWlmci5pZnJfZmxhZ3MgPSAodGFwX3R5cGUp ID8gSUZGX1RBUCA6IElGRl9UVU4gfCBJRkZfUE9JTlRPUE9JTlQ7DQo+ICsJaWZyLmlmcl9mbGFn cyA9IChwbWQtPnR5cGUgPT0gRVRIX1RVTlRBUF9UWVBFX1RBUCkgPw0KPiArCQkJSUZGX1RBUCA6 IElGRl9UVU4gfCBJRkZfUE9JTlRPUE9JTlQ7DQo+IAlzbnByaW50ZihpZnIuaWZyX25hbWUsIElG TkFNU0laLCAiJXMiLCBwbWQtPm5hbWUpOw0KPiANCj4gCVRBUF9MT0coREVCVUcsICJpZnJfbmFt ZSAnJXMnIiwgaWZyLmlmcl9uYW1lKTsNCj4gQEAgLTUwMiwyMCArNTAzLDI0IEBAIHBtZF90eF9i dXJzdCh2b2lkICpxdWV1ZSwgc3RydWN0IHJ0ZV9tYnVmICoqYnVmcywgdWludDE2X3QgbmJfcGt0 cykNCj4gCQlpZiAocnRlX3BrdG1idWZfcGt0X2xlbihtYnVmKSA+IG1heF9zaXplKQ0KPiAJCQli cmVhazsNCj4gDQo+IC0JCS8qDQo+IC0JCSAqIFRVTiBhbmQgVEFQIGFyZSBjcmVhdGVkIHdpdGgg SUZGX05PX1BJIGRpc2FibGVkLg0KPiAtCQkgKiBGb3IgVFVOIFBNRCB0aGlzIG1hbmRhdG9yeSBh cyBmaWVsZHMgYXJlIHVzZWQgYnkNCj4gLQkJICogS2VybmVsIHR1bi5jIHRvIGRldGVybWluZSB3 aGV0aGVyIGl0cyBJUCBvciBub24gSVANCj4gLQkJICogcGFja2V0cy4NCj4gLQkJICoNCj4gLQkJ ICogVGhlIGxvZ2ljIGZldGNoZXMgdGhlIGZpcnN0IGJ5dGUgb2YgZGF0YSBmcm9tIG1idWYuDQo+ IC0JCSAqIGNvbXBhcmVzIHdoZXRoZXIgaXRzIHY0IG9yIHY2LiBJZiBub25lIG1hdGNoZXMgZGVm YXVsdA0KPiAtCQkgKiB2YWx1ZSAweDAwIGlzIHRha2VuIGZvciBwcm90b2NvbCBmaWVsZC4NCj4g LQkJICovDQo+IC0JCWNoYXIgKmJ1ZmZfZGF0YSA9IHJ0ZV9wa3RtYnVmX210b2Qoc2VnLCB2b2lk ICopOw0KPiAtCQlqID0gKCpidWZmX2RhdGEgJiAweGYwKTsNCj4gLQkJcGkucHJvdG8gPSAoaiA9 PSAweDQwKSA/IDB4MDAwOCA6DQo+IC0JCQkJKGogPT0gMHg2MCkgPyAweGRkODYgOiAweDAwOw0K PiArCQlpZiAodHhxLT50eXBlID09IEVUSF9UVU5UQVBfVFlQRV9UVU4pIHsNCj4gKwkJCS8qDQo+ ICsJCQkgKiBUVU4gYW5kIFRBUCBhcmUgY3JlYXRlZCB3aXRoIElGRl9OT19QSSBkaXNhYmxlZC4N Cj4gKwkJCSAqIEZvciBUVU4gUE1EIHRoaXMgbWFuZGF0b3J5IGFzIGZpZWxkcyBhcmUgdXNlZCBi eQ0KPiArCQkJICogS2VybmVsIHR1bi5jIHRvIGRldGVybWluZSB3aGV0aGVyIGl0cyBJUCBvciBu b24gSVANCj4gKwkJCSAqIHBhY2tldHMuDQo+ICsJCQkgKg0KPiArCQkJICogVGhlIGxvZ2ljIGZl dGNoZXMgdGhlIGZpcnN0IGJ5dGUgb2YgZGF0YSBmcm9tIG1idWYuDQo+ICsJCQkgKiBjb21wYXJl cyB3aGV0aGVyIGl0cyB2NCBvciB2Ni4gSWYgbm9uZSBtYXRjaCBkZWZhdWx0DQo+ICsJCQkgKiB2 YWx1ZSAweDAwIGlzIHRha2VuIGZvciBwcm90b2NvbCBmaWVsZC4NCg0KTGl0dGxlIHJld29yZCBh bmQgcmVtb3ZlIHRoZSDigJgu4oCZIGF0IGVuZCBvZiBmaXJzdCBsaW5lLg0KDQpUaGUgbG9naWMg ZmV0Y2hlcyB0aGUgZmlyc3QgYnl0ZSBvZiBkYXRhIGZyb20gbWJ1ZiB0aGVuIGNvbXBhcmVzIHdo ZXRoZXIgaXQgaXMgdjQgb3IgdjYuIElmIG5vdCBlcXVhbCB0byB6ZXJvIHRoZW4gaXQgbXVzdCBi ZSBhIHByb3RvY29sIGZpZWxkLg0KDQoNCg0KPiArCQkJICovDQo+ICsJCQljaGFyICpidWZmX2Rh dGEgPSBydGVfcGt0bWJ1Zl9tdG9kKHNlZywgdm9pZCAqKTsNCj4gKwkJCWogPSAoKmJ1ZmZfZGF0 YSAmIDB4ZjApOw0KPiArCQkJcGkucHJvdG8gPSAoaiA9PSAweDQwKSA/IDB4MDAwOCA6DQo+ICsJ CQkJCShqID09IDB4NjApID8gMHhkZDg2IDogMHgwMDsNCj4gKwkJCXByaW50ZigiaiAleCBwaSBw cm90byAleFxuIiwgaiwgcGkucHJvdG8pOw0KDQpTaG91bGQgdGhpcyBub3QgYmUgYSBMT0cgbWVz c2FnZSBvciBpcyB0aGlzIGRlYnVnIHRoYXQgd2FzIG5vdCByZW1vdmVkPyBJZiBsb2cgbWVzc2Fn ZSB0aGVuIGFkZCBtb3ZlIHRleHQgdG8gZXhwbGFpbiB0aGUgb3V0cHV0IGJldHRlci4NCg0KPiAr CQkJcnRlX3BrdG1idWZfZHVtcChzdGRvdXQsIHNlZywgNjQpOw0KPiArCQl9DQo+IA0KPiAJCWlv dmVjc1swXS5pb3ZfYmFzZSA9ICZwaTsNCj4gCQlpb3ZlY3NbMF0uaW92X2xlbiA9IHNpemVvZihw aSk7DQo+IEBAIC0xMDUyLDYgKzEwNTcsOSBAQCB0YXBfc2V0dXBfcXVldWUoc3RydWN0IHJ0ZV9l dGhfZGV2ICpkZXYsDQo+IAl0eC0+bXR1ID0gJmRldi0+ZGF0YS0+bXR1Ow0KPiAJcngtPnJ4bW9k ZSA9ICZkZXYtPmRhdGEtPmRldl9jb25mLnJ4bW9kZTsNCj4gDQo+ICsJdHgtPnR5cGUgPSBwbWQt PnR5cGU7DQo+ICsJcngtPnR5cGUgPSBwbWQtPnR5cGU7DQo+ICsNCj4gCXJldHVybiAqZmQ7DQo+ IH0NCj4gDQo+IEBAIC0xMzg2LDYgKzEzOTQsNyBAQCBldGhfZGV2X3RhcF9jcmVhdGUoc3RydWN0 IHJ0ZV92ZGV2X2RldmljZSAqdmRldiwgY2hhciAqdGFwX25hbWUsDQo+IAlwbWQgPSBkZXYtPmRh dGEtPmRldl9wcml2YXRlOw0KPiAJcG1kLT5kZXYgPSBkZXY7DQo+IAlzbnByaW50ZihwbWQtPm5h bWUsIHNpemVvZihwbWQtPm5hbWUpLCAiJXMiLCB0YXBfbmFtZSk7DQo+ICsJcG1kLT50eXBlID0g RVRIX1RVTlRBUF9UWVBFX1VOS05PV047DQo+IA0KPiAJcG1kLT5pb2N0bF9zb2NrID0gc29ja2V0 KEFGX0lORVQsIFNPQ0tfREdSQU0sIDApOw0KPiAJaWYgKHBtZC0+aW9jdGxfc29jayA9PSAtMSkg ew0KPiBAQCAtMTQyMSw3ICsxNDMwLDkgQEAgZXRoX2Rldl90YXBfY3JlYXRlKHN0cnVjdCBydGVf dmRldl9kZXZpY2UgKnZkZXYsIGNoYXIgKnRhcF9uYW1lLA0KPiAJCXBtZC0+dHhxW2ldLmZkID0g LTE7DQo+IAl9DQo+IA0KPiAtCWlmICh0YXBfdHlwZSkgew0KPiArCXBtZC0+dHlwZSA9ICh0YXBf dHlwZSkgPyBFVEhfVFVOVEFQX1RZUEVfVEFQIDogRVRIX1RVTlRBUF9UWVBFX1RVTjsNCj4gKw0K PiArCWlmIChwbWQtPnR5cGUgPT0gRVRIX1RVTlRBUF9UWVBFX1RBUCkgew0KPiAJCWlmIChpc196 ZXJvX2V0aGVyX2FkZHIobWFjX2FkZHIpKQ0KPiAJCQlldGhfcmFuZG9tX2FkZHIoKHVpbnQ4X3Qg KikmcG1kLT5ldGhfYWRkcik7DQo+IAkJZWxzZQ0KPiBAQCAtMTQ0MCw3ICsxNDUxLDcgQEAgZXRo X2Rldl90YXBfY3JlYXRlKHN0cnVjdCBydGVfdmRldl9kZXZpY2UgKnZkZXYsIGNoYXIgKnRhcF9u YW1lLA0KPiAJaWYgKHRhcF9pb2N0bChwbWQsIFNJT0NTSUZNVFUsICZpZnIsIDEsIExPQ0FMX0FO RF9SRU1PVEUpIDwgMCkNCj4gCQlnb3RvIGVycm9yX2V4aXQ7DQo+IA0KPiAtCWlmICh0YXBfdHlw ZSkgew0KPiArCWlmIChwbWQtPnR5cGUgPT0gRVRIX1RVTlRBUF9UWVBFX1RBUCkgew0KPiAJCW1l bXNldCgmaWZyLCAwLCBzaXplb2Yoc3RydWN0IGlmcmVxKSk7DQo+IAkJaWZyLmlmcl9od2FkZHIu c2FfZmFtaWx5ID0gQUZfTE9DQUw7DQo+IAkJcnRlX21lbWNweShpZnIuaWZyX2h3YWRkci5zYV9k YXRhLCAmcG1kLT5ldGhfYWRkciwNCj4gQEAgLTE4MTIsNyArMTgyMyw5IEBAIHJ0ZV9wbWRfdGFw X3JlbW92ZShzdHJ1Y3QgcnRlX3ZkZXZfZGV2aWNlICpkZXYpDQo+IAlzdHJ1Y3QgcG1kX2ludGVy bmFscyAqaW50ZXJuYWxzOw0KPiAJaW50IGk7DQo+IA0KPiAtCVRBUF9MT0coREVCVUcsICJDbG9z aW5nIFRVTi9UQVAgRXRoZXJuZXQgZGV2aWNlIG9uIG51bWEgJXUiLA0KPiArCWludGVybmFscyA9 IGV0aF9kZXYtPmRhdGEtPmRldl9wcml2YXRlOw0KPiArCVRBUF9MT0coREVCVUcsICJDbG9zaW5n ICVzIEV0aGVybmV0IGRldmljZSBvbiBudW1hICV1IiwNCj4gKwkJKGludGVybmFscy0+dHlwZSA9 PSBFVEhfVFVOVEFQX1RZUEVfVEFQKSA/ICJUQVAiIDogIlRVTiIsDQo+IAkJcnRlX3NvY2tldF9p ZCgpKTsNCj4gDQo+IAkvKiBmaW5kIHRoZSBldGhkZXYgZW50cnkgKi8NCj4gQEAgLTE4MjAsNyAr MTgzMyw2IEBAIHJ0ZV9wbWRfdGFwX3JlbW92ZShzdHJ1Y3QgcnRlX3ZkZXZfZGV2aWNlICpkZXYp DQo+IAlpZiAoIWV0aF9kZXYpDQo+IAkJcmV0dXJuIDA7DQo+IA0KPiAtCWludGVybmFscyA9IGV0 aF9kZXYtPmRhdGEtPmRldl9wcml2YXRlOw0KPiAJaWYgKGludGVybmFscy0+bmxza19mZCkgew0K PiAJCXRhcF9mbG93X2ZsdXNoKGV0aF9kZXYsIE5VTEwpOw0KPiAJCXRhcF9mbG93X2ltcGxpY2l0 X2ZsdXNoKGludGVybmFscywgTlVMTCk7DQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL25ldC90YXAv cnRlX2V0aF90YXAuaCBiL2RyaXZlcnMvbmV0L3RhcC9ydGVfZXRoX3RhcC5oDQo+IGluZGV4IDY3 YzlkNGIuLjhiMGRhNWEgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvbmV0L3RhcC9ydGVfZXRoX3Rh cC5oDQo+ICsrKyBiL2RyaXZlcnMvbmV0L3RhcC9ydGVfZXRoX3RhcC5oDQo+IEBAIC0yMyw2ICsy MywxMyBAQA0KPiAjZGVmaW5lIFJURV9QTURfVEFQX01BWF9RVUVVRVMJMQ0KPiAjZW5kaWYNCj4g DQo+ICtlbnVtIHJ0ZV90dW50YXBfdHlwZSB7DQo+ICsJRVRIX1RVTlRBUF9UWVBFX1VOS05PV04s DQo+ICsJRVRIX1RVTlRBUF9UWVBFX1RVTiwNCj4gKwlFVEhfVFVOVEFQX1RZUEVfVEFQLA0KPiAr CUVUSF9UVU5UQVBfVFlQRV9NQVgsDQo+ICt9Ow0KPiArDQo+IHN0cnVjdCBwa3Rfc3RhdHMgew0K PiAJdWludDY0X3Qgb3BhY2tldHM7ICAgICAgICAgICAgICAvKiBOdW1iZXIgb2Ygb3V0cHV0IHBh Y2tldHMgKi8NCj4gCXVpbnQ2NF90IGlwYWNrZXRzOyAgICAgICAgICAgICAgLyogTnVtYmVyIG9m IGlucHV0IHBhY2tldHMgKi8NCj4gQEAgLTM4LDYgKzQ1LDcgQEAgc3RydWN0IHJ4X3F1ZXVlIHsN Cj4gCXVpbnQzMl90IHRyaWdnZXJfc2VlbjsgICAgICAgICAgLyogTGFzdCBzZWVuIFJ4IHRyaWdn ZXIgdmFsdWUgKi8NCj4gCXVpbnQxNl90IGluX3BvcnQ7ICAgICAgICAgICAgICAgLyogUG9ydCBJ RCAqLw0KPiAJaW50IGZkOw0KPiArCWludCB0eXBlOwkJCSAgLyogVHlwZSBmaWVsZCAtIFRVTnxU QVAgKi8NCj4gCXN0cnVjdCBwa3Rfc3RhdHMgc3RhdHM7ICAgICAgICAgLyogU3RhdHMgZm9yIHRo aXMgUlggcXVldWUgKi8NCj4gCXVpbnQxNl90IG5iX3J4X2Rlc2M7ICAgICAgICAgICAgLyogbWF4 IG51bWJlciBvZiBtYnVmcyBhdmFpbGFibGUgKi8NCj4gCXN0cnVjdCBydGVfZXRoX3J4bW9kZSAq cnhtb2RlOyAgLyogUlggZmVhdHVyZXMgKi8NCj4gQEAgLTQ4LDYgKzU2LDcgQEAgc3RydWN0IHJ4 X3F1ZXVlIHsNCj4gDQo+IHN0cnVjdCB0eF9xdWV1ZSB7DQo+IAlpbnQgZmQ7DQo+ICsJaW50IHR5 cGU7CQkJICAvKiBUeXBlIGZpZWxkIC0gVFVOfFRBUCAqLw0KPiAJdWludDE2X3QgKm10dTsgICAg ICAgICAgICAgICAgICAvKiBQb2ludGVyIHRvIE1UVSBmcm9tIGRldl9kYXRhICovDQo+IAl1aW50 MTZfdCBjc3VtOjE7ICAgICAgICAgICAgICAgIC8qIEVuYWJsZSBjaGVja3N1bSBvZmZsb2FkaW5n ICovDQo+IAlzdHJ1Y3QgcGt0X3N0YXRzIHN0YXRzOyAgICAgICAgIC8qIFN0YXRzIGZvciB0aGlz IFRYIHF1ZXVlICovDQo+IEBAIC01Nyw2ICs2Niw3IEBAIHN0cnVjdCBwbWRfaW50ZXJuYWxzIHsN Cj4gCXN0cnVjdCBydGVfZXRoX2RldiAqZGV2OyAgICAgICAgICAvKiBFdGhlcm5ldCBkZXZpY2Uu ICovDQo+IAljaGFyIHJlbW90ZV9pZmFjZVtSVEVfRVRIX05BTUVfTUFYX0xFTl07IC8qIFJlbW90 ZSBuZXRkZXZpY2UgbmFtZSAqLw0KPiAJY2hhciBuYW1lW1JURV9FVEhfTkFNRV9NQVhfTEVOXTsg IC8qIEludGVybmFsIFRhcCBkZXZpY2UgbmFtZSAqLw0KPiArCWludCB0eXBlOwkJCSAgLyogVHlw ZSBmaWVsZCAtIFRVTnxUQVAgKi8NCj4gCXN0cnVjdCBldGhlcl9hZGRyIGV0aF9hZGRyOyAgICAg ICAvKiBNYWMgYWRkcmVzcyBvZiB0aGUgZGV2aWNlIHBvcnQgKi8NCj4gCXN0cnVjdCBpZnJlcSBy ZW1vdGVfaW5pdGlhbF9mbGFnczsgICAvKiBSZW1vdGUgbmV0ZGV2aWNlIGZsYWdzIG9uIGluaXQg Ki8NCj4gCWludCByZW1vdGVfaWZfaW5kZXg7ICAgICAgICAgICAgICAvKiByZW1vdGUgbmV0ZGV2 aWNlIElGX0lOREVYICovDQo+IC0tIA0KPiAyLjcuNA0KPiANCg0KUmVnYXJkcywNCktlaXRoDQoN Cg==