DPDK patches and discussions
 help / color / mirror / Atom feed
From: <hfli@netitest.com>
To: <dev@dpdk.org>
Subject: 回复: af_packet can't send packet more than framecnt
Date: Mon, 20 Mar 2023 19:36:02 +0800	[thread overview]
Message-ID: <1CCF1B14C9842CED+002501d95b20$272f1b60$758d5220$@netitest.com> (raw)
In-Reply-To: 

Hi,

The issue has been resolved when I patched new code from dpdk 22.12, my dpdk
version is 19.11

Index: rte_eth_af_packet.c
===================================================================
--- rte_eth_af_packet.c (版本 44115)
+++ rte_eth_af_packet.c (版本 44128)
@@ -169,6 +169,29 @@
 }
 
 /*
+ * Check if there is an available frame in the ring
+ */
+static inline int
+tx_ring_status_available(uint32_t tp_status)
+{
+       /*
+        * We eliminate the timestamp status from the packet status.
+        * This should only matter if timestamping is enabled on the socket,
+        * but there is a bug in the kernel which is fixed in newer
releases.
+        *
+        * See the following kernel commit for reference:
+        *     commit 171c3b151118a2fe0fc1e2a9d1b5a1570cfe82d2
+        *     net: packetmmap: fix only tx timestamp on request
+        */
+       tp_status &= ~(TP_STATUS_TS_SOFTWARE | TP_STATUS_TS_RAW_HARDWARE);
+
+       if (tp_status == TP_STATUS_AVAILABLE)
+        return 1;
+
+    return 0;
+}
+
+/*
  * Callback to handle sending packets through a real NIC.
  */
 static uint16_t
@@ -213,7 +236,7 @@
                }
 
                /* point at the next incoming frame */
-               if (ppd->tp_status != TP_STATUS_AVAILABLE) {
+               if (!tx_ring_status_available(ppd->tp_status)) {
                        if (poll(&pfd, 1, -1) < 0)
                                break;
 
@@ -236,7 +259,7 @@
                 *
                 * This results in poll() returning POLLOUT.
                 */
-               if (ppd->tp_status != TP_STATUS_AVAILABLE)
+               if (!tx_ring_status_available(ppd->tp_status))
                        break;
 
                /* copy the tx frame data */


Thanks,
Haifeng

-----邮件原件-----
发件人: hfli@netitest.com <hfli@netitest.com> 
发送时间: 2023年3月20日 11:32
收件人: 'dev@dpdk.org' <dev@dpdk.org>
主题: af_packet can't send packet more than framecnt

Hi,

I used af_packet interface, but found only can send packets successfully
less than framecnt argument. 

E.g. if I pass “--vdev=eth_af_packet0,iface=tap0,blocksz=4096,framesz=2048,
framecnt=512,qpairs=1,qdisc_bypass=0” to DPDK, the rte_eth_tx_burst only
return 1 for 512 times, after that it always return 0.
If I pass
“--vdev=eth_af_packet0,iface=tap0,blocksz=4096,framesz=2048,framecnt=1024,q
pairs=1,qdisc_bypass=0” to DPDK, the rte_eth_tx_burst only return 1 for
1024 times, after that it always return 0.

BTW, I use busy loop mode in project, Is there any help for this?



Thanks so much
Haifeng


             reply	other threads:[~2023-03-20 11:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-20 11:36 hfli [this message]
2023-03-20 16:53 ` Stephen Hemminger
2023-03-21  1:00   ` 回复: " hfli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='1CCF1B14C9842CED+002501d95b20$272f1b60$758d5220$@netitest.com' \
    --to=hfli@netitest.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).