From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 0ABAC2A5E for ; Fri, 3 Mar 2017 16:19:43 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Mar 2017 07:19:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,237,1484035200"; d="scan'208";a="830569317" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 03 Mar 2017 07:19:42 -0800 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 3 Mar 2017 07:19:42 -0800 Received: from fmsmsx113.amr.corp.intel.com ([169.254.13.17]) by fmsmsx121.amr.corp.intel.com ([169.254.6.23]) with mapi id 14.03.0248.002; Fri, 3 Mar 2017 07:19:42 -0800 From: "Wiles, Keith" To: Pascal Mazon CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/tap: fix dev name look-up Thread-Index: AQHSk/vvpgtB5ZhQ90aruQhnYomA/qGDwUqA Date: Fri, 3 Mar 2017 15:19:41 +0000 Message-ID: <1D7A781E-071D-4F3D-BC82-FD9A9338953E@intel.com> References: <1ad979ca71ba1ebe10572237a6a5b4694c23b645.1488531158.git.pascal.mazon@6wind.com> In-Reply-To: <1ad979ca71ba1ebe10572237a6a5b4694c23b645.1488531158.git.pascal.mazon@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.49.209] Content-Type: text/plain; charset="us-ascii" Content-ID: <7F9E693E13245B4082A78A77B52101E6@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/tap: fix dev name look-up X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Mar 2017 15:19:44 -0000 > On Mar 3, 2017, at 2:54 AM, Pascal Mazon wrote: >=20 > The call to rte_eth_dev_allocate(tap_name) sets dev->data->name to > tap_name (e.g. "dtap0"). >=20 > A look-up using tap_name is expected to return this device, not a > look-up using name (e.g. "net_tap0"). >=20 > Signed-off-by: Pascal Mazon Acked-by: Keith Wiles > --- > drivers/net/tap/rte_eth_tap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.= c > index 47a706070652..14c345f07afa 100644 > --- a/drivers/net/tap/rte_eth_tap.c > +++ b/drivers/net/tap/rte_eth_tap.c > @@ -691,7 +691,7 @@ eth_dev_tap_create(const char *name, char *tap_name) > dev->driver =3D NULL; > dev->rx_pkt_burst =3D pmd_rx_burst; > dev->tx_pkt_burst =3D pmd_tx_burst; > - snprintf(dev->data->name, sizeof(dev->data->name), "%s", name); > + snprintf(dev->data->name, sizeof(dev->data->name), "%s", tap_name); >=20 > /* Presetup the fds to -1 as being not valid */ > for (i =3D 0; i < RTE_PMD_TAP_MAX_QUEUES; i++) { > --=20 > 2.8.0.rc0 >=20 Regards, Keith