Re: [dpdk-dev] [PATCH v2]xen:reserve memory at installing dom0_mm kernel module

["Liu, Jijiang" <jijiang.liu@intel.com>]

Thanks.
I Will add changelog for next time.

-----Original Message-----
From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] 
Sent: Friday, May 23, 2014 4:20 PM
To: Liu, Jijiang
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2]xen:reserve memory at installing dom0_mm kernel module

Hi Jijiang,

2014-05-23 14:53, Jijiang Liu:
> The patch changes the way of reserving memory in Dom0 driver. It will 
> reserve memory at installing rte_dom0_mm.ko kernel module instead of 
> requesting memory dynamically during DPDK application startup. 
> Meanwhile, now driver requests memory size of 4M once first, if it 
> failed, and request memory size of 2M once. The main reasons we do these changes as follows:
> 
> First, to reduce the impact of inceasing in memory fragment after 
> system run a long time. Second, to reduce number of memory segment
> 
> Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>
> ---

Thanks for sending new version of this patch.

Just a note for next time, as explained in this page:
	http://dpdk.org/dev#send
it's a good practice do put a changelog after the 3 dashes. It allows to us to understand why this new version is for.

In this case, the changelog should be:

changes in v2:
- fix code style according to checkpatch.pl

Thanks
--
Thomas