From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 8BE87593A for ; Fri, 23 May 2014 10:25:09 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 23 May 2014 01:25:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.98,892,1392192000"; d="scan'208";a="545415392" Received: from fmsmsx107.amr.corp.intel.com ([10.19.9.54]) by orsmga002.jf.intel.com with ESMTP; 23 May 2014 01:25:17 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX107.amr.corp.intel.com (10.19.9.54) with Microsoft SMTP Server (TLS) id 14.3.123.3; Fri, 23 May 2014 01:25:17 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.7]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.192]) with mapi id 14.03.0123.003; Fri, 23 May 2014 16:25:15 +0800 From: "Liu, Jijiang" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v2]xen:reserve memory at installing dom0_mm kernel module Thread-Index: AQHPdl/hNfroyqAJ90SzoptP4tjGEJtN085g Date: Fri, 23 May 2014 08:25:15 +0000 Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC01C7941D@SHSMSX101.ccr.corp.intel.com> References: <1400827990-14324-1-git-send-email-jijiang.liu@intel.com> <5649427.rlZUqcKHhV@xps13> In-Reply-To: <5649427.rlZUqcKHhV@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2]xen:reserve memory at installing dom0_mm kernel module X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 May 2014 08:25:10 -0000 Thanks. I Will add changelog for next time. -----Original Message----- From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]=20 Sent: Friday, May 23, 2014 4:20 PM To: Liu, Jijiang Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2]xen:reserve memory at installing dom0_mm = kernel module Hi Jijiang, 2014-05-23 14:53, Jijiang Liu: > The patch changes the way of reserving memory in Dom0 driver. It will=20 > reserve memory at installing rte_dom0_mm.ko kernel module instead of=20 > requesting memory dynamically during DPDK application startup.=20 > Meanwhile, now driver requests memory size of 4M once first, if it=20 > failed, and request memory size of 2M once. The main reasons we do these = changes as follows: >=20 > First, to reduce the impact of inceasing in memory fragment after=20 > system run a long time. Second, to reduce number of memory segment >=20 > Signed-off-by: Jijiang Liu > --- Thanks for sending new version of this patch. Just a note for next time, as explained in this page: http://dpdk.org/dev#send it's a good practice do put a changelog after the 3 dashes. It allows to us= to understand why this new version is for. In this case, the changelog should be: changes in v2: - fix code style according to checkpatch.pl Thanks -- Thomas