Re: [dpdk-dev] [PATCH 0/3] *** Upgrade NIC share codes ***

["Liu, Jijiang" <jijiang.liu@intel.com>]

This is a batch update of the code in DPDK to align it with the latest versions of the common device driver code for Intel network devices, such as is used in the Linux and BSD drivers. Intel DPDK team get periodic updates from the networking division at Intel, and we apply those without modifications to the code in the ixgbe and e1000 subfolders of the DPDK codebase. Each code-drop provides us with the latest device support and bug fixes. 

The code-drop was tested by the ND team ,and Intel DPDK team receive the code-drop without individual commit history, as mentioned earlier, this is a batch update. 
Furthermore, before sending patches to dpdk.org, in order to guarantee no new issues are introduced by upgrading, Intel DPDK team has done development and test of integration, and don't change any source codes in these drivers in the meantime. 
At present, the common device code should be treated as read-only, any bugs found here will be collected and reported to Intel.

Thanks
Frank

-----Original Message-----
From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] 
Sent: Monday, May 19, 2014 5:18 PM
To: Liu, Jijiang
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 0/3] *** Upgrade NIC share codes ***

Hi Jijiang,

I feel there is a lot of important changes in these patches but I cannot easily read them. Splitting in many small patches with nice commit logs would help a lot.
Please refer to http://dpdk.org/dev#send in order to understand what must be a good patch.

At least, you should make patches for minor changes (whitespace/typo/case), few patches for new features (e.g. M88E1512, SFP+ laser) and few patches for bug fixes (e.g. pll_workaround_i210, locks, fc-autoneg, vf link).

Especially, an explanation is needed for locking changes as there were some work on it in these commits:
	http://dpdk.org/browse/dpdk/commit/?id=4c9d8ed203c1170e4cc11
	http://dpdk.org/browse/dpdk/commit/?id=f283b30509d2db745e746

"git add -p" could help you to split the changes into several commits.
You can check how minor changes in base driver were handled previously.
Examples from version 1.5.1:
	http://dpdk.org/browse/dpdk/commit/?id=1558bea6e3723d9c1
	http://dpdk.org/browse/dpdk/commit/?id=2fd4855f306e9df38
	http://dpdk.org/browse/dpdk/commit/?id=5037620be576a3c20
	http://dpdk.org/browse/dpdk/commit/?id=1d2d65121bd10ba95

Thanks
--
Thomas