From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id BF97B7E76 for ; Thu, 16 Oct 2014 03:16:43 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 15 Oct 2014 18:18:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,728,1406617200"; d="scan'208";a="619559649" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga002.jf.intel.com with ESMTP; 15 Oct 2014 18:24:33 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 15 Oct 2014 18:24:33 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 15 Oct 2014 18:24:32 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.203]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.204]) with mapi id 14.03.0195.001; Thu, 16 Oct 2014 09:24:31 +0800 From: "Liu, Jijiang" To: "De Lara Guarch, Pablo" Thread-Topic: [dpdk-dev] [PATCH v5 4/8]librte_ether:add a common filter API Thread-Index: AQHP5RggfROQBkzJQEK2KXnfI24S+pwxRByQgACxWDA= Date: Thu, 16 Oct 2014 01:24:30 +0000 Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC01D771C1@SHSMSX101.ccr.corp.intel.com> References: <1413006935-22535-1-git-send-email-jijiang.liu@intel.com> <1413006935-22535-5-git-send-email-jijiang.liu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v5 4/8]librte_ether:add a common filter API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Oct 2014 01:16:44 -0000 > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Thursday, October 16, 2014 12:01 AM > To: Liu, Jijiang; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v5 4/8]librte_ether:add a common filter AP= I >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jijiang Liu > > Sent: Saturday, October 11, 2014 6:56 AM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH v5 4/8]librte_ether:add a common filter API > > > > Introduce a new filter framewok in librte_ether. As to the > > implemetation discussion, please refer to > > http://dpdk.org/ml/archives/dev/2014-September/005179.html, and VxLAN > > tunnel filter implementation is based on it. > > > > Signed-off-by: Jijiang Liu > > Acked-by: Helin Zhang > > Acked-by: Jingjing Wu > > > > --- > > lib/librte_ether/Makefile | 1 + > > lib/librte_ether/rte_eth_ctrl.h | 152 > > +++++++++++++++++++++++++++++++++++++++ > > lib/librte_ether/rte_ethdev.c | 32 ++++++++ > > lib/librte_ether/rte_ethdev.h | 56 +++++++++++--- > > 4 files changed, 229 insertions(+), 12 deletions(-) create mode > > 100644 lib/librte_ether/rte_eth_ctrl.h > > > [...] > > +++ b/lib/librte_ether/rte_eth_ctrl.h >=20 > [...] >=20 > > +/** > > + * Tunnel Packet filter configuration. > > + */ > > +struct rte_eth_tunnel_filter_conf { > > + struct ether_addr *outer_mac; /**< Outer MAC address fiter. */ > > + struct ether_addr *inner_mac; /**< Inner MAC address fiter. */ > > + uint16_t inner_vlan; /**< Inner VLAN fiter. */ > > + enum rte_tunnel_iptype ip_type; /**< IP address type. */ > > + union { > > + uint32_t ipv4_addr; /**< IPv4 source address to match. */ > > + uint32_t ipv6_addr[4]; /**< IPv6 source address to match. */ > > + } ip_addr; /**< IPv4/IPv6 source address to match (union of above). > > */ > > + > > + uint8_t filter_type; /**< Filter type. */ >=20 > This should be enum rte_tunnel_filter_type filter_type, and not uint8_t > filter_type. I will fix this. > > + uint8_t to_queue; /**< Use MAC and VLAN to point to a queue. > > */ > > + enum rte_eth_tunnel_type tunnel_type; /**< Tunnel Type. */ > > + uint32_t tenant_id; /** < Tenant number. */ > > + uint16_t queue_id; /** < queue number. */ > > +}; > > + > [...]