From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 942BD7E79 for ; Fri, 17 Oct 2014 07:13:04 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 16 Oct 2014 22:10:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,737,1406617200"; d="scan'208";a="606835127" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 16 Oct 2014 22:20:59 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 16 Oct 2014 22:20:59 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 16 Oct 2014 22:20:58 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.203]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.204]) with mapi id 14.03.0195.001; Fri, 17 Oct 2014 13:20:51 +0800 From: "Liu, Jijiang" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v5 7/8]i40e:support VxLAN Tx checksum offload Thread-Index: AQHP6YCww69GMjHKFkmGd7d8WbZUapwzwMiQ Date: Fri, 17 Oct 2014 05:20:51 +0000 Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC01D77671@SHSMSX101.ccr.corp.intel.com> References: <1413006935-22535-1-git-send-email-jijiang.liu@intel.com> <1413006935-22535-8-git-send-email-jijiang.liu@intel.com> <2679158.ldaB3mIRM3@xps13> In-Reply-To: <2679158.ldaB3mIRM3@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v5 7/8]i40e:support VxLAN Tx checksum offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Oct 2014 05:13:05 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Friday, October 17, 2014 4:34 AM > To: Liu, Jijiang > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 7/8]i40e:support VxLAN Tx checksum > offload >=20 > 2014-10-11 13:55, Jijiang Liu: > > Support VxLAN Tx checksum offload, which include > > - outer L3(IP) checksum offload > > - inner L3(IP) checksum offload > > - inner L4(UDP, TCP and SCTP) checksum offload > [...] > > + > > + /* fields to support tunnelling packet TX offloads */ >=20 > I know that previous comment is "fields to support TX offloads", but I'd > prefer "for TX offloading of tunnels". > Maybe that "encapsulation" is better than "tunnel". > Just my opinion. >=20 > > + union { > > + /**< combined inner l2/l3 lengths as single var */ > > + uint16_t inner_l2_l3_len; > > + > > + struct { > > + /**< inner L3 (IP) Header Length. */ > > + uint16_t inner_l3_len:9; > > + > > + /**< L2 (MAC) Header Length. */ > > + uint16_t inner_l2_len:7; > > + }; > > + }; >=20 > I would like to highlight that you are using 2 bytes in the second cache = line of > the mbuf. > It deserves at least a line in the commit log. > Actually I'd prefer a separate patch for mbuf modifications. >=20 > Thanks > -- > Thomas Ok, I will send a separate patch for mbuf modifications. Thanks Jijiang Liu