Re: [dpdk-dev] [PATCH v5 2/8]i40e:support VxLAN packet identification in librte_pmd_i40e

["Liu, Jijiang" <jijiang.liu@intel.com>]

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Friday, October 17, 2014 3:57 AM
> To: Liu, Jijiang
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v5 2/8]i40e:support VxLAN packet
> identification in librte_pmd_i40e
> 
> 2014-10-11 13:55, Jijiang Liu:
> >  #
> > +# Compile tunneling UDP port support
> > +#
> > +CONFIG_RTE_LIBRTE_TUNNEL_UDP_PORT=4789
> > +
> > +#
> 
> 1) this option is not to "Compile tunneling UDP port support"
Change the comment as "tunneling UDP default port configuration"
> 2) why is it a compile time option? should it be an API parameter or a
> runtime option?

In terms of VxLAN, "IANA has assigned the value 4789 for the VXLAN UDP port, and this value SHOULD be used by default as the
 destination UDP port.  Some early implementations of VXLAN have used other values for the destination port.  To enable
interoperability with these implementations, the destination port SHOULD be configurable."

I have provided a API to configure UDP port. But a default UDP port number is needed where PF startup if current mode is VxLAN mode.

> > +	uint16_t packet_type;     /**< Packet type, which indicates packet
> format */
> 
> It's not very clear what packet type is.
> There is maybe a more precise description, or is it hardware dependent?

As to why to add packet_type in mbuf structure, there are lots of explanations in 
Discussion of "[PATCH 03/13] mbuf: add packet_type field"
Anyway, I will add detailed description here.
 
> >  static struct i40e_veb *i40e_veb_setup(struct i40e_pf *pf,
> > -						struct i40e_vsi *vsi);
> > +					struct i40e_vsi *vsi);
> 
> It's not related to VXLAN.
> --
> Thomas