From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <jijiang.liu@intel.com> Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 8E6F77E7E for <dev@dpdk.org>; Fri, 17 Oct 2014 07:50:53 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 16 Oct 2014 22:58:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,737,1406617200"; d="scan'208";a="606846688" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga001.fm.intel.com with ESMTP; 16 Oct 2014 22:58:48 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 16 Oct 2014 22:58:49 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.203]) by shsmsx102.ccr.corp.intel.com ([169.254.2.192]) with mapi id 14.03.0195.001; Fri, 17 Oct 2014 13:58:47 +0800 From: "Liu, Jijiang" <jijiang.liu@intel.com> To: Thomas Monjalon <thomas.monjalon@6wind.com> Thread-Topic: [dpdk-dev] [PATCH v5 2/8]i40e:support VxLAN packet identification in librte_pmd_i40e Thread-Index: AQHP6XtePohUl6jluUGPooamIhL3yZwzw6kw Date: Fri, 17 Oct 2014 05:58:46 +0000 Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC01D776A2@SHSMSX101.ccr.corp.intel.com> References: <1413006935-22535-1-git-send-email-jijiang.liu@intel.com> <1413006935-22535-3-git-send-email-jijiang.liu@intel.com> <3781474.dkZOSRuQuF@xps13> In-Reply-To: <3781474.dkZOSRuQuF@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" <dev@dpdk.org> Subject: Re: [dpdk-dev] [PATCH v5 2/8]i40e:support VxLAN packet identification in librte_pmd_i40e X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 17 Oct 2014 05:50:54 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Friday, October 17, 2014 3:57 AM > To: Liu, Jijiang > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 2/8]i40e:support VxLAN packet > identification in librte_pmd_i40e >=20 > 2014-10-11 13:55, Jijiang Liu: > > # > > +# Compile tunneling UDP port support > > +# > > +CONFIG_RTE_LIBRTE_TUNNEL_UDP_PORT=3D4789 > > + > > +# >=20 > 1) this option is not to "Compile tunneling UDP port support" Change the comment as "tunneling UDP default port configuration" > 2) why is it a compile time option? should it be an API parameter or a > runtime option? In terms of VxLAN, "IANA has assigned the value 4789 for the VXLAN UDP port= , and this value SHOULD be used by default as the destination UDP port. Some early implementations of VXLAN have used other= values for the destination port. To enable interoperability with these implementations, the destination port SHOULD be= configurable." I have provided a API to configure UDP port. But a default UDP port number = is needed where PF startup if current mode is VxLAN mode. > > + uint16_t packet_type; /**< Packet type, which indicates packet > format */ >=20 > It's not very clear what packet type is. > There is maybe a more precise description, or is it hardware dependent? As to why to add packet_type in mbuf structure, there are lots of explanati= ons in=20 Discussion of "[PATCH 03/13] mbuf: add packet_type field" Anyway, I will add detailed description here. =20 > > static struct i40e_veb *i40e_veb_setup(struct i40e_pf *pf, > > - struct i40e_vsi *vsi); > > + struct i40e_vsi *vsi); >=20 > It's not related to VXLAN. > -- > Thomas