From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 98A017E80 for ; Mon, 20 Oct 2014 03:19:01 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 19 Oct 2014 18:27:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,749,1406617200"; d="scan'208";a="621581661" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by orsmga002.jf.intel.com with ESMTP; 19 Oct 2014 18:27:07 -0700 Received: from kmsmsx152.gar.corp.intel.com (172.21.73.87) by PGSMSX101.gar.corp.intel.com (10.221.44.78) with Microsoft SMTP Server (TLS) id 14.3.195.1; Mon, 20 Oct 2014 09:25:52 +0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by KMSMSX152.gar.corp.intel.com (172.21.73.87) with Microsoft SMTP Server (TLS) id 14.3.195.1; Mon, 20 Oct 2014 09:25:52 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.202]) by shsmsx102.ccr.corp.intel.com ([169.254.2.156]) with mapi id 14.03.0195.001; Mon, 20 Oct 2014 09:25:51 +0800 From: "Liu, Jijiang" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v5 2/8]i40e:support VxLAN packet identification in librte_pmd_i40e Thread-Index: AQHP6XtePohUl6jluUGPooamIhL3yZwzw6kw//+eVgCABNPawA== Date: Mon, 20 Oct 2014 01:25:50 +0000 Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC01D7FDBE@SHSMSX101.ccr.corp.intel.com> References: <1413006935-22535-1-git-send-email-jijiang.liu@intel.com> <3781474.dkZOSRuQuF@xps13> <1ED644BD7E0A5F4091CF203DAFB8E4CC01D776A2@SHSMSX101.ccr.corp.intel.com> <9682370.k5Gd5eGDQ1@xps13> In-Reply-To: <9682370.k5Gd5eGDQ1@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v5 2/8]i40e:support VxLAN packet identification in librte_pmd_i40e X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Oct 2014 01:19:02 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Friday, October 17, 2014 3:40 PM > To: Liu, Jijiang > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 2/8]i40e:support VxLAN packet > identification in librte_pmd_i40e >=20 > 2014-10-17 05:58, Liu, Jijiang: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > 2014-10-11 13:55, Jijiang Liu: > > > > # > > > > +# Compile tunneling UDP port support # > > > > +CONFIG_RTE_LIBRTE_TUNNEL_UDP_PORT=3D4789 > > > > + > > > > +# > > > > > > 1) this option is not to "Compile tunneling UDP port support" > > Change the comment as "tunneling UDP default port configuration" > > > 2) why is it a compile time option? should it be an API parameter or > > > a runtime option? > > > > In terms of VxLAN, "IANA has assigned the value 4789 for the VXLAN UDP > > port, and this value SHOULD be used by default as the destination UDP > port. > > Some early implementations of VXLAN have used other values for the > > destination port. To enable interoperability with these > > implementations, the destination port SHOULD be configurable." >=20 > Please, do not consider a compile time option like "configurable". > There are some cases where the user cannot or don't want to rebuild DPDK. >=20 > > I have provided a API to configure UDP port. >=20 > OK, good. >=20 > > But a default UDP port number is needed where PF startup if current > > mode is VxLAN mode. >=20 > Sorry, I don't understand this part. > Why are you adding a default tunnel when initializing? > Is it not enough to allow adding new tunnels with custom port? Ok, I will remove this default UDP port configuration, just allow to use AP= I to add/remove UDP port number.=20 > -- > Thomas