From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id C95A17E99 for ; Tue, 21 Oct 2014 20:20:28 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 21 Oct 2014 11:23:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,762,1406617200"; d="scan'208";a="593107113" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by orsmga001.jf.intel.com with ESMTP; 21 Oct 2014 07:14:39 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by PGSMSX101.gar.corp.intel.com (10.221.44.78) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 21 Oct 2014 22:14:38 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.202]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.44]) with mapi id 14.03.0195.001; Tue, 21 Oct 2014 22:14:37 +0800 From: "Liu, Jijiang" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v6 1/9] librte_mbuf:the rte_mbuf structure changes Thread-Index: AQHP7QuBLMZEchCEm0mRzkz7lTfp/pw50rwAgAC/uLA= Date: Tue, 21 Oct 2014 14:14:37 +0000 Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC01D82548@SHSMSX101.ccr.corp.intel.com> References: <1413881168-20239-1-git-send-email-jijiang.liu@intel.com> <1413881168-20239-2-git-send-email-jijiang.liu@intel.com> <2450996.3KDeDxoTz7@xps13> In-Reply-To: <2450996.3KDeDxoTz7@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v6 1/9] librte_mbuf:the rte_mbuf structure changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Oct 2014 18:20:30 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Tuesday, October 21, 2014 6:26 PM > To: Liu, Jijiang > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v6 1/9] librte_mbuf:the rte_mbuf structure > changes >=20 > Hi Jijiang, >=20 > 2014-10-21 16:46, Jijiang Liu: > > Remove the "reserved2" field and add the "packet_type" >=20 > "Remove and add" can be said "Replace". >=20 > > and the "inner_l2_l3_len" fields in the rte_mbuf structure. >=20 > Please explain that you are using 2 bytes of the second cache line for TX > offloading of tunnels. >=20 > > /* remaining bytes are set on RX when pulling packet from descriptor > */ > > MARKER rx_descriptor_fields1; > > - uint16_t reserved2; /**< Unused field. Required for padding */ > > + > > + /** > > + * Packet type, which is used to indicate ordinary L2 packet format > and > > + * also tunneled packet format such as IP in IP, IP in GRE, MAC in GR= E > > + * and MAC in UDP. > > + */ > > + uint16_t packet_type; >=20 > Why not name it "l2_type"? In datasheet, this term is called packet type(s). Personally , I think packet type is more clear what meaning of this field = is . ^_^ > -- > Thomas