From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 695F06A96 for ; Wed, 22 Oct 2014 07:44:24 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 21 Oct 2014 22:47:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="403947724" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by FMSMGA003.fm.intel.com with ESMTP; 21 Oct 2014 22:45:03 -0700 Received: from pgsmsx102.gar.corp.intel.com (10.221.44.80) by PGSMSX101.gar.corp.intel.com (10.221.44.78) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 22 Oct 2014 13:51:04 +0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by PGSMSX102.gar.corp.intel.com (10.221.44.80) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 22 Oct 2014 13:51:04 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.202]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.207]) with mapi id 14.03.0195.001; Wed, 22 Oct 2014 13:51:03 +0800 From: "Liu, Jijiang" To: Marc Sune Thread-Topic: [dpdk-dev] [PATCH v4] KNI: use a memzone pool for KNI alloc/release Thread-Index: AQHP7QlKeydI7PuWFk+LpWkd2Bui95w52fQAgAHDnEA= Date: Wed, 22 Oct 2014 05:51:03 +0000 Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC01D8288F@SHSMSX101.ccr.corp.intel.com> References: <1413586289-6694-1-git-send-email-marc.sune@bisdn.de> <11046523.OQamTbecJT@xps13> <54463ADC.8080901@bisdn.de> In-Reply-To: <54463ADC.8080901@bisdn.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v4] KNI: use a memzone pool for KNI alloc/release X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Oct 2014 05:44:25 -0000 There is a compilation error using gcc version 4.6.2. ./lib/librte_kni/rte_kni.c:134:15: error: missing initializer [-Werror=3Dmi= ssing-field-initializers] /lib/librte_kni/rte_kni.c:134:15: error: (near initialization for kni_memzo= ne_pool.max_iface? [-Werror=3Dmissing-field-initializers] cc1: all warnings being treated as errors > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Marc Sune > Sent: Tuesday, October 21, 2014 6:52 PM > To: Thomas Monjalon > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4] KNI: use a memzone pool for KNI > alloc/release >=20 > Thomas, >=20 > v5: commit message arranged, all warnings from checkpatch.pl fixed except= : >=20 > WARNING: Macros with flow control statements should be avoided > #104: FILE: lib/librte_kni/rte_kni.c:62: > +#define KNI_MEM_CHECK(cond) do { if (cond) goto kni_fail; } while (0) >=20 > a) This MACRO was there before, I just re-factored it to make it more > readable. > b) There are 4 lines exceeding 80cols due to long quoted strings. I follo= wed > kernel convention not to split them in multiple lines. >=20 > Thanks and regards > Marc >=20 > On 21/10/14 10:29, Thomas Monjalon wrote: > > Hi Marc, > > > > 2014-10-18 00:51, Marc Sune: > >> This patch implements the KNI memzone pool in order to prevent > >> memzone exhaustion when allocating/deallocating KNI interfaces. > >> > >> It adds a new API call, rte_kni_init(max_kni_ifaces) that shall be > >> called before any call to rte_kni_alloc() if KNI is used. > >> > >> v2: Moved KNI fd opening to rte_kni_init(). Revised style. > >> v3: Adapted kni examples/tests to rte_kni_init(). > >> v4: Improved example integration. Fixed > kni_memzone_pool_alloc/release() bug. > >> > >> Signed-off-by: Marc Sune > > Thanks for the good work with Helin. > > Before applying this patch, I'd like another version explaining in the > > commit log why this change is needed. > > And please use to checkpatch.pl to check and remove whitespace errors. > > > > Thanks