From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 21F39593A for ; Wed, 22 Oct 2014 10:47:21 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 22 Oct 2014 01:55:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,767,1406617200"; d="scan'208";a="618398688" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by fmsmga002.fm.intel.com with ESMTP; 22 Oct 2014 01:55:39 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by PGSMSX101.gar.corp.intel.com (10.221.44.78) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 22 Oct 2014 16:53:49 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.202]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.207]) with mapi id 14.03.0195.001; Wed, 22 Oct 2014 16:53:48 +0800 From: "Liu, Jijiang" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v6 1/9] librte_mbuf:the rte_mbuf structure changes Thread-Index: AQHP7QuBLMZEchCEm0mRzkz7lTfp/pw50rwAgAC/uLCAALZzAIAAhz4w Date: Wed, 22 Oct 2014 08:53:48 +0000 Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC01D8297A@SHSMSX101.ccr.corp.intel.com> References: <1413881168-20239-1-git-send-email-jijiang.liu@intel.com> <2450996.3KDeDxoTz7@xps13> <1ED644BD7E0A5F4091CF203DAFB8E4CC01D82548@SHSMSX101.ccr.corp.intel.com> <1710340.mrZid3JfsP@xps13> In-Reply-To: <1710340.mrZid3JfsP@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v6 1/9] librte_mbuf:the rte_mbuf structure changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Oct 2014 08:47:23 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, October 22, 2014 4:46 PM > To: Liu, Jijiang > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v6 1/9] librte_mbuf:the rte_mbuf structure > changes >=20 > 2014-10-21 14:14, Liu, Jijiang: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > 2014-10-21 16:46, Jijiang Liu: > > > > - uint16_t reserved2; /**< Unused field. Required for padding= */ > > > > + > > > > + /** > > > > + * Packet type, which is used to indicate ordinary L2 packet form= at > and > > > > + * also tunneled packet format such as IP in IP, IP in GRE, MAC i= n GRE > > > > + * and MAC in UDP. > > > > + */ > > > > + uint16_t packet_type; > > > > > > Why not name it "l2_type"? > > > > In datasheet, this term is called packet type(s). >=20 > That's exactly the point I want you really understand! > This is a field in generic mbuf structure, so your datasheet has no value= here. >=20 > > Personally , I think packet type is more clear what meaning of this fi= eld is . > ^_^ >=20 > You cannot add an API field without knowing what will be its generic > meaning. > Please think about it and describe its scope. its generic meaning is that each UNIT number stand for a kind of packet f= ormat=1B$B!#=1B(B I will add more description for this field. > Thanks > -- > Thomas