From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 0E31C7E7B for ; Wed, 22 Oct 2014 15:51:16 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 22 Oct 2014 06:55:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,769,1406617200"; d="scan'208";a="609313216" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by fmsmga001.fm.intel.com with ESMTP; 22 Oct 2014 06:55:01 -0700 Received: from pgsmsx102.gar.corp.intel.com (10.221.44.80) by PGSMSX101.gar.corp.intel.com (10.221.44.78) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 22 Oct 2014 21:54:59 +0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by PGSMSX102.gar.corp.intel.com (10.221.44.80) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 22 Oct 2014 21:54:59 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.202]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.174]) with mapi id 14.03.0195.001; Wed, 22 Oct 2014 21:54:58 +0800 From: "Liu, Jijiang" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v6 5/9] librte_ether:add data structures of VxLAN filter Thread-Index: AQHP7QuJFKbMRL7JK0C/1AlzdyzoJ5w6ItQAgAGI6PD//6gyAIAAzp7Q Date: Wed, 22 Oct 2014 13:54:58 +0000 Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC01D82AC8@SHSMSX101.ccr.corp.intel.com> References: <1413881168-20239-1-git-send-email-jijiang.liu@intel.com> <1893361.J7EnPDFulE@xps13> <1ED644BD7E0A5F4091CF203DAFB8E4CC01D828AA@SHSMSX101.ccr.corp.intel.com> <3142740.MjSjxYyKcT@xps13> In-Reply-To: <3142740.MjSjxYyKcT@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v6 5/9] librte_ether:add data structures of VxLAN filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Oct 2014 13:51:18 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, October 22, 2014 5:25 PM > To: Liu, Jijiang > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v6 5/9] librte_ether:add data structures o= f > VxLAN filter >=20 > 2014-10-22 06:45, Liu, Jijiang: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > 2014-10-21 16:46, Jijiang Liu: > > > > +#define RTE_TUNNEL_FILTER_TO_QUEUE 1 /**< point to an queue by > > > > +filter > > > type */ > > > > > > Sorry, I don't understand what is this value for? > > > > This MACRO is used to indicate if user application hope to filter > > incoming packet(s) to a specific queue(multi-queue configuration is > > required) using filter type(such as inner MAC + tenant ID). > > If the flag is not set, and all incoming packet will always go to > > queue 0. >=20 > 1) It's a boolean, so a new constant is not required. OK. define bool to_queue.=20 > 2) You set the variable "to_queue" with this value but the variable is no= t > used > 3) Is there a sense to add a filter with this variable to 0? >=20 > I think "to_queue" variable and this constant are useless. No, It is useful. I will change to_queue to be configurable.=20 > PS: it seems I'm the only person worried by the filtering API. > So maybe we shouldn't integrate it at all? I know you are joking.=20 We should certainly integrate the feature into dpdk.org > -- > Thomas