From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id B06B52A9 for ; Thu, 27 Nov 2014 13:07:54 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 27 Nov 2014 04:04:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,469,1413270000"; d="scan'208";a="614957738" Received: from pgsmsx107.gar.corp.intel.com ([10.221.44.105]) by orsmga001.jf.intel.com with ESMTP; 27 Nov 2014 04:07:52 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.110.14) by PGSMSX107.gar.corp.intel.com (10.221.44.105) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 27 Nov 2014 20:07:51 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.110]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.240]) with mapi id 14.03.0195.001; Thu, 27 Nov 2014 20:07:50 +0800 From: "Liu, Jijiang" To: Olivier MATZ , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 0/3] i40e VXLAN TX checksum rework Thread-Index: AQHQChvO5Hbj694uHUagPyQ5KbGpNZxzszuAgACtwzA= Date: Thu, 27 Nov 2014 12:07:49 +0000 Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC01D9EE3F@SHSMSX101.ccr.corp.intel.com> References: <1417076319-629-1-git-send-email-jijiang.liu@intel.com> <5476F28F.7010802@6wind.com> In-Reply-To: <5476F28F.7010802@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 0/3] i40e VXLAN TX checksum rework X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Nov 2014 12:07:55 -0000 > -----Original Message----- > From: Olivier MATZ [mailto:olivier.matz@6wind.com] > Sent: Thursday, November 27, 2014 5:45 PM > To: Liu, Jijiang; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/3] i40e VXLAN TX checksum rework >=20 > Hi Jijiang, >=20 > Please find below some comments about the specifications. The global pict= ure > looks fine to me. >=20 > I've not reviewed the patch right now, but it's in the pipe. >=20 > On 11/27/2014 09:18 AM, Jijiang Liu wrote: > > We have got some feedback about backward compatibility of VXLAN TX > checksum offload API with 1G/10G NIC after the i40e VXLAN TX checksum cod= es > were applied, so we have to rework the APIs on i40e, including the change= s of > mbuf, i40e PMD and csum engine. > > > > The main changes in mbuf are as follows, In place of removing > > PKT_TX_VXLAN_CKSUM, we introducing 2 new flags: PKT_TX_OUT_IP_CKSUM, > PKT_TX_UDP_TUNNEL_PKT, and a new field: l4_tun_len. >=20 > What about PKT_TX_OUT_UDP_CKSUM instead of PKT_TX_UDP_TUNNEL_PKT? > It's maybe more coherent with the other names. >=20 >=20 > > Replace the inner_l2_len and the inner_l3_len field with the outer_l2_l= en and > outer_l3_len field. > > > > The existing flags are listed below, > > PKT_TX_IP_CKSUM: HW IPv4 checksum for non-tunnelling packet/ HW inn= er > IPv4 checksum for tunnelling packet > > PKT_TX_TCP_CKSUM: HW TCP checksum for non-tunnelling packet/ HW inne= r > TCP checksum for tunnelling packet > > PKT_TX_SCTP_CKSUM: HW SCTP checksum for non-tunnelling packet/ HW > inner SCTP checksum for tunnelling packet > > PKT_TX_UDP_CKSUM: HW SCTP checksum for non-tunnelling packet/ HW > inner SCTP checksum for tunnelling packet > > PKT_TX_IPV4: IPv4 with no HW checksum offload for non-tunnelling > packet/inner IPv4 with no HW checksum offload for tunnelling packet > > PKT_TX_IPV6: IPv6 non-tunnelling packet/ inner IPv6 with no HW c= hecksum > offload for tunnelling packet >=20 > As I suggested in the TSO thread, I think the following semantics is easi= er to > understand for the user: >=20 > - PKT_TX_IP_CKSUM: tell the NIC to compute IP cksum >=20 > - PKT_TX_IPV4: tell the NIC it's an IPv4 packet. Required for L4 > checksum offload or TSO. >=20 > - PKT_TX_IPV6: tell the NIC it's an IPv6 packet. Required for L4 > checksum offload or TSO. >=20 > I think it won't make a big difference in the FVL driver. >=20 Ok.