From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 5A9182A9 for ; Thu, 27 Nov 2014 14:14:13 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP; 27 Nov 2014 05:11:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,469,1413270000"; d="scan'208";a="644512755" Received: from pgsmsx105.gar.corp.intel.com ([10.221.44.96]) by orsmga002.jf.intel.com with ESMTP; 27 Nov 2014 05:14:10 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by pgsmsx105.gar.corp.intel.com (10.221.44.96) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 27 Nov 2014 21:14:08 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.110]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.86]) with mapi id 14.03.0195.001; Thu, 27 Nov 2014 21:14:08 +0800 From: "Liu, Jijiang" To: Olivier MATZ , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/3] mbuf:add two TX offload flags and change three fields Thread-Index: AQHQCij3gT8zSau+ukaSqjkBc7C0OJx0Yx8w Date: Thu, 27 Nov 2014 13:14:07 +0000 Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC01D9EE79@SHSMSX101.ccr.corp.intel.com> References: <1417076319-629-1-git-send-email-jijiang.liu@intel.com> <1417076319-629-2-git-send-email-jijiang.liu@intel.com> <5476F626.2020708@6wind.com> In-Reply-To: <5476F626.2020708@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/3] mbuf:add two TX offload flags and change three fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Nov 2014 13:14:14 -0000 > -----Original Message----- > From: Olivier MATZ [mailto:olivier.matz@6wind.com] > Sent: Thursday, November 27, 2014 6:00 PM > To: Liu, Jijiang; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/3] mbuf:add two TX offload flags and cha= nge > three fields >=20 > Hi Jijiang, >=20 > Please see some comments below. >=20 > On 11/27/2014 09:18 AM, Jijiang Liu wrote: > > In place of removing the PKT_TX_VXLAN_CKSUM, we introduce 2 new flags: > PKT_TX_OUT_IP_CKSUM, PKT_TX_UDP_TUNNEL_PKT, and a new field: > l4_tun_len. > > Replace the inner_l2_len and the inner_l3_len field with the outer_l2_l= en and > outer_l3_len field. > > > > PKT_TX_OUT_IP_CKSUM: is not used for non-tunnelling packet;hardware out= er > checksum for tunnelling packet. > > PKT_TX_UDP_TUNNEL_PKT: is used to tell PMD that the transmit packet is = a > UDP tunneling packet. > > l4_tun_len: for VXLAN packet, it should be udp header length plus VXLAN > header length. > > > > Signed-off-by: Jijiang Liu > > --- > > lib/librte_mbuf/rte_mbuf.c | 2 +- > > lib/librte_mbuf/rte_mbuf.h | 23 ++++++++++++++--------- > > 2 files changed, 15 insertions(+), 10 deletions(-) > > > > diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c > > index 87c2963..e89c310 100644 > > --- a/lib/librte_mbuf/rte_mbuf.c > > +++ b/lib/librte_mbuf/rte_mbuf.c > > @@ -240,7 +240,7 @@ const char *rte_get_tx_ol_flag_name(uint64_t mask) > > case PKT_TX_SCTP_CKSUM: return "PKT_TX_SCTP_CKSUM"; > > case PKT_TX_UDP_CKSUM: return "PKT_TX_UDP_CKSUM"; > > case PKT_TX_IEEE1588_TMST: return "PKT_TX_IEEE1588_TMST"; > > - case PKT_TX_VXLAN_CKSUM: return "PKT_TX_VXLAN_CKSUM"; > > + case PKT_TX_UDP_TUNNEL_PKT: return "PKT_TX_UDP_TUNNEL_PKT"; > > case PKT_TX_TCP_SEG: return "PKT_TX_TCP_SEG"; > > default: return NULL; >=20 > As I said as a reply to the cover letter, I suggest to use > PKT_TX_OUT_UDP_CKSUM instead of PKT_TX_UDP_TUNNEL_PKT. >=20 > Also, the PKT_TX_OUT_IP_CKSUM case is missing here. Yes. > > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h > > index 367fc56..48cd8e1 100644 > > --- a/lib/librte_mbuf/rte_mbuf.h > > +++ b/lib/librte_mbuf/rte_mbuf.h > > @@ -99,10 +99,9 @@ extern "C" { > > #define PKT_RX_TUNNEL_IPV6_HDR (1ULL << 12) /**< RX tunnel packet wit= h > IPv6 header. */ > > #define PKT_RX_FDIR_ID (1ULL << 13) /**< FD id reported if FDIR= match. > */ > > #define PKT_RX_FDIR_FLX (1ULL << 14) /**< Flexible bytes reporte= d if FDIR > match. */ > > -/* add new RX flags here */ > > >=20 > We should probably not remove this line. Why? There are two lines "/* add new RX flags here */" in rte_mbuf.h file. >=20 > > /* add new TX flags here */ > > -#define PKT_TX_VXLAN_CKSUM (1ULL << 50) /**< TX checksum of VXLAN > computed by NIC */ > > +#define PKT_TX_UDP_TUNNEL_PKT (1ULL << 50) /**< TX packet is an UDP > > +tunneling packet */ > > #define PKT_TX_IEEE1588_TMST (1ULL << 51) /**< TX IEEE1588 packet to > > timestamp. */ > > > > /** > > @@ -125,13 +124,20 @@ extern "C" { > > #define PKT_TX_IP_CKSUM (1ULL << 54) /**< IP cksum of TX pkt. co= mputed > by NIC. */ > > #define PKT_TX_IPV4_CSUM PKT_TX_IP_CKSUM /**< Alias of > PKT_TX_IP_CKSUM. */ > > > > +#define PKT_TX_VLAN_PKT (1ULL << 55) /**< TX packet is a 802.1q V= LAN > packet. */ > > + > > /** Tell the NIC it's an IPv4 packet. Required for L4 checksum offloa= d or TSO. > */ > > -#define PKT_TX_IPV4 PKT_RX_IPV4_HDR > > +#define PKT_TX_IPV4 (1ULL << 56) > > > > /** Tell the NIC it's an IPv6 packet. Required for L4 checksum offloa= d or TSO. > */ > > -#define PKT_TX_IPV6 PKT_RX_IPV6_HDR > > +#define PKT_TX_IPV6 (1ULL << 57) >=20 > The description in comment does not match the description in the cover le= tter. Change cover letter. > Also, I think replacing PKT_RX_IPV[46]_HDR by the value may go in another > commit. Ok. >=20 > > -#define PKT_TX_VLAN_PKT (1ULL << 55) /**< TX packet is a 802.1q V= LAN > packet. */ > > +/** Outer IP cksum of TX pkt. computed by NIC for tunneling packet */ > > +#define PKT_TX_OUTER_IP_CKSUM (1ULL << 58) > > +#define PKT_TX_OUTER_IPV4_CSUM PKT_TX_OUTER_IP_CKSUM /**< Alias > of > > +PKT_TX_OUTER_IP_CKSUM. */ >=20 > Why do we need an alias? Ok, remove it. > By the way, I think the alias of PKT_TX_IP_CKSUM is also uneeded and can = be > removed. But it's not the topic of your series. >=20 > Also, the name PKT_TX_OUTER_IP_CKSUM does not match the name in the cover > letter and commit logs. >=20 >=20 > > + > > +/** Tell the NIC it's an outer IPv6 packet for tunneling packet.*/ > > +#define PKT_TX_OUTER_IPV6 (1ULL << 59) > > >=20 > This flag is not in the cover letter or commit log. What is its purpose? >=20 With FVL, if outer L3 header is IPv6, to make HW TX checksum offload work ,= SW must be responsible to tell hardware this information.