From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jijiang.liu@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id D32A47F00
 for <dev@dpdk.org>; Fri, 28 Nov 2014 11:33:49 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga101.fm.intel.com with ESMTP; 28 Nov 2014 02:33:48 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.07,475,1413270000"; d="scan'208";a="639492739"
Received: from pgsmsx106.gar.corp.intel.com ([10.221.44.98])
 by fmsmga002.fm.intel.com with ESMTP; 28 Nov 2014 02:33:20 -0800
Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by
 pgsmsx106.gar.corp.intel.com (10.221.44.98) with Microsoft SMTP Server (TLS)
 id 14.3.195.1; Fri, 28 Nov 2014 18:33:19 +0800
Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.110]) by
 SHSMSX104.ccr.corp.intel.com ([169.254.5.182]) with mapi id 14.03.0195.001;
 Fri, 28 Nov 2014 18:33:13 +0800
From: "Liu, Jijiang" <jijiang.liu@intel.com>
To: Olivier MATZ <olivier.matz@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH v3 1/4] mbuf:add three TX offload flags and
 change three fields
Thread-Index: AQHQCu7lrNwCUSJ3+kKStC5noR8mpJx11Vgg
Date: Fri, 28 Nov 2014 10:33:12 +0000
Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC01D9F2B9@SHSMSX101.ccr.corp.intel.com>
References: <1417107801-9544-1-git-send-email-jijiang.liu@intel.com>
 <1417107801-9544-2-git-send-email-jijiang.liu@intel.com>
 <54784232.8030707@6wind.com>
In-Reply-To: <54784232.8030707@6wind.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v3 1/4] mbuf:add three TX offload flags and
 change three fields
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Nov 2014 10:33:50 -0000

Hi Olivier,

> -----Original Message-----
> From: Olivier MATZ [mailto:olivier.matz@6wind.com]
> Sent: Friday, November 28, 2014 5:37 PM
> To: Liu, Jijiang; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 1/4] mbuf:add three TX offload flags an=
d
> change three fields
>=20
> Hi Jijiang,
>=20
> On 11/27/2014 06:03 PM, Jijiang Liu wrote:
> >  /** Tell the NIC it's an IPv4 packet. Required for L4 checksum offload=
 or TSO.
> */
> >  #define PKT_TX_IPV4          PKT_RX_IPV4_HDR
> >
> >  /** Tell the NIC it's an IPv6 packet. Required for L4 checksum offload=
 or TSO.
> */
> >  #define PKT_TX_IPV6          PKT_RX_IPV6_HDR
>=20
> The description still does not match what we discussed. Either we have
> PKT_TX_IPV4 meaning "packet is IPv4 without requiring IP cksum offload", =
or
> "packet is IPv4". I prefer the second one, but whatever the choice is, th=
e
> comments must be coherent.
>
I agree.
 "packet is IPv4" is ok for me, too.
The comment "Required for L4 checksum offload or TSO" is not added by me,  =
I should have thought you added it during developing TSO.
Anyway, we came to an agreement for  PKT_TX_IPV6/4 meaning, I will change  =
the two flags comments.