From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id E97338041 for ; Fri, 12 Dec 2014 05:08:41 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 11 Dec 2014 20:07:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,561,1413270000"; d="scan'208";a="652657436" Received: from kmsmsx153.gar.corp.intel.com ([172.21.73.88]) by orsmga002.jf.intel.com with ESMTP; 11 Dec 2014 20:08:30 -0800 Received: from kmsmsx154.gar.corp.intel.com (172.21.73.14) by KMSMSX153.gar.corp.intel.com (172.21.73.88) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 12 Dec 2014 12:06:25 +0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by KMSMSX154.gar.corp.intel.com (172.21.73.14) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 12 Dec 2014 12:06:24 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.110]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.182]) with mapi id 14.03.0195.001; Fri, 12 Dec 2014 12:06:24 +0800 From: "Liu, Jijiang" To: Olivier MATZ , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 3/3] app/testpmd:change tx_checksum command and csum forwarding engine Thread-Index: AQHQFBUh0WPyTjHFLkGXaMd1Nvg3yJyJst8AgAGi3PA= Date: Fri, 12 Dec 2014 04:06:22 +0000 Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC01DA1B93@SHSMSX101.ccr.corp.intel.com> References: <1418173403-30202-1-git-send-email-jijiang.liu@intel.com> <1418173403-30202-4-git-send-email-jijiang.liu@intel.com> <54897774.6090107@6wind.com> In-Reply-To: <54897774.6090107@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 3/3] app/testpmd:change tx_checksum command and csum forwarding engine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Dec 2014 04:08:44 -0000 > -----Original Message----- > From: Olivier MATZ [mailto:olivier.matz@6wind.com] > Sent: Thursday, December 11, 2014 6:53 PM > To: Liu, Jijiang; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 3/3] app/testpmd:change tx_checksum > command and csum forwarding engine >=20 > Hi Jijiang, >=20 > Some more comments, in addition to the one I've made in the cover letter. > Reference link for patchwork readers: > http://dpdk.org/ml/archives/dev/2014-December/009886.html >=20 > On 12/10/2014 02:03 AM, Jijiang Liu wrote: > > --- a/app/test-pmd/cmdline.c > > +++ b/app/test-pmd/cmdline.c > > @@ -316,16 +316,30 @@ static void cmd_help_long_parsed(void > *parsed_result, > > " Disable hardware insertion of a VLAN header in" > > " packets sent on a port.\n\n" > > > > - "tx_cksum set (ip|udp|tcp|sctp|vxlan) (hw|sw) > (port_id)\n" > > + "tx_cksum set (ip|udp|tcp|sctp) (hw|sw) (port_id)\n" > > " Select hardware or software calculation of the" > > " checksum with when transmitting a packet using the" > > " csum forward engine.\n" > > - " ip|udp|tcp|sctp always concern the inner layer.\n" > > - " vxlan concerns the outer IP and UDP layer (in" > > - " case the packet is recognized as a vxlan packet by" > > - " the forward engine)\n" > > + " In the case of tunneling packet, ip|udp|tcp|sctp" > > + " always concern the inner layer.\n\n" > > + > > + "tx_cksum set tunnel (hw|sw|none) (port_id)\n" > > + " Select hardware or software calculation of the" > > + " checksum with when transmitting a tunneling packet" > > + " using the csum forward engine.\n" > > + " The none option means treat tunneling packet as > ordinary" > > + " packet when using the csum forward engine\n." > > + " Tunneling packet concerns the outer IP, inner IP" > > + " and inner L4\n" > > " Please check the NIC datasheet for HW limits.\n\n" > > > > + "tx_cksum set (outer-ip) (hw|sw) (port_id)\n" > > + " Select hardware or software calculation of the" > > + " checksum with when transmitting a packet using the" > > + " csum forward engine.\n" > > + " outer-ip always concern the outer layer of" > > + " tunneling packet.\n\n" > > + > > "tx_checksum show (port_id)\n" > > " Display tx checksum offload configuration\n\n" > > >=20 > not sure we need 2 different commands for tx_cksum set (outer-ip) and tx_= cksum > set (ip|udp|tcp|sctp). As the syntax is exactly the same, it may result i= n less code > to have only one command. Why do we have a separate command for outer layer, I have explained this in= other mail. Do you agree on this? =20 >=20 > > --- a/app/test-pmd/csumonly.c > > +++ b/app/test-pmd/csumonly.c > > @@ -256,17 +256,16 @@ process_outer_cksums(void *outer_l3_hdr, uint16_t > outer_ethertype, > > struct udp_hdr *udp_hdr; > > uint64_t ol_flags =3D 0; > > > > - if (testpmd_ol_flags & TESTPMD_TX_OFFLOAD_VXLAN_CKSUM) > > - ol_flags |=3D PKT_TX_UDP_TUNNEL_PKT; > > - > > if (outer_ethertype =3D=3D _htons(ETHER_TYPE_IPv4)) { > > ipv4_hdr->hdr_checksum =3D 0; > > > > - if (testpmd_ol_flags & TESTPMD_TX_OFFLOAD_VXLAN_CKSUM) > > + if (testpmd_ol_flags & > TESTPMD_TX_OFFLOAD_OUTER_IP_CKSUM) > > ol_flags |=3D PKT_TX_OUTER_IP_CKSUM; > > - else > > + else { > > ipv4_hdr->hdr_checksum =3D rte_ipv4_cksum(ipv4_hdr); > > - } else if (testpmd_ol_flags & TESTPMD_TX_OFFLOAD_VXLAN_CKSUM) > > + ol_flags |=3D PKT_TX_OUTER_IPV4; > > + } > > + } else if (testpmd_ol_flags & TESTPMD_TX_OFFLOAD_TUNNEL_CKSUM) > > ol_flags |=3D PKT_TX_OUTER_IPV6; > > > > udp_hdr =3D (struct udp_hdr *)((char *)outer_l3_hdr + outer_l3_len); > > @@ -300,11 +299,14 @@ process_outer_cksums(void *outer_l3_hdr, uint16_t > outer_ethertype, > > * Ether / (vlan) / outer IP|IP6 / outer UDP / VxLAN / Ether / IP|I= P6 / > > * UDP|TCP|SCTP > > * > > - * The testpmd command line for this forward engine sets the flags > > + * These testpmd command lines for this forward engine sets the flags > > * TESTPMD_TX_OFFLOAD_* in ports[tx_port].tx_ol_flags. They control > > - * wether a checksum must be calculated in software or in hardware. > > The > > - * IP, UDP, TCP and SCTP flags always concern the inner layer. The > > - * VxLAN flag concerns the outer IP (if packet is recognized as a vxla= n packet). > > + * wether a checksum must be calculated in software or in hardware. > > + * In the case of tunneling packet, the IP, UDP, TCP and SCTP flags > > + * always concern the inner layer; the outer IP flag always concern > > + * the outer layer; the tunnel flag is used to tell the NIC that it > > + * is a tunneing packet, want hardware offload for outer layer, > > + * or inner layer, or both. >=20 > tunneing -> tunneling >=20 > "the tunnel flag is used to tell the NIC that it is a tunneing packet, wa= nt hardware > offload for outer layer, or inner layer, or both." >=20 > what does that mean? Ok, Will replace the above the description with the following: The tunnel flag is used to set/clear the flag of enabling TX tunneling pac= ket checksum hardware offload in application. >=20 >=20 > > */ > > static void > > pkt_burst_checksum_forward(struct fwd_stream *fs) @@ -376,7 +378,9 > > @@ pkt_burst_checksum_forward(struct fwd_stream *fs) > > l3_hdr =3D (char *)eth_hdr + l2_len; > > > > /* check if it's a supported tunnel (only vxlan for now) */ > > - if (l4_proto =3D=3D IPPROTO_UDP) { > > + if (((testpmd_ol_flags & > > + TESTPMD_TX_OFFLOAD_NON_TUNNEL_CKSUM) =3D=3D 0) > > + && (l4_proto =3D=3D IPPROTO_UDP)) { > > udp_hdr =3D (struct udp_hdr *)((char *)l3_hdr + l3_len); > > > > /* check udp destination port, 4789 is the default @@ - > 386,17 > > +390,23 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) > > tunnel =3D 1; > > > > /* currently, this flag is set by i40e only if the > > - * packet is vxlan */ > > + * packet is a tunneling packet */ > > } else if (m->ol_flags & (PKT_RX_TUNNEL_IPV4_HDR | > > PKT_RX_TUNNEL_IPV6_HDR)) > > tunnel =3D 1; > > > > if (tunnel =3D=3D 1) { > > + > > + if (testpmd_ol_flags > > + & > TESTPMD_TX_OFFLOAD_TUNNEL_CKSUM) > > + ol_flags |=3D PKT_TX_UDP_TUNNEL_PKT; > > + > > outer_ethertype =3D ethertype; > > outer_l2_len =3D l2_len; > > outer_l3_len =3D l3_len; > > outer_l3_hdr =3D l3_hdr; > > > > + /* currently, only VXLAN packet is supported */ > > eth_hdr =3D (struct ether_hdr *)((char *)udp_hdr + > > sizeof(struct udp_hdr) + > > sizeof(struct vxlan_hdr)); > > @@ -434,7 +444,7 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) > > /* step 4: fill the mbuf meta data (flags and header lengths) */ > > > > if (tunnel =3D=3D 1) { > > - if (testpmd_ol_flags & > TESTPMD_TX_OFFLOAD_VXLAN_CKSUM) { > > + if (testpmd_ol_flags & > TESTPMD_TX_OFFLOAD_TUNNEL_CKSUM) { > > m->outer_l2_len =3D outer_l2_len; > > m->outer_l3_len =3D outer_l3_len; > > m->l2_len =3D l4_tun_len + l2_len; @@ -505,7 > +515,7 @@ > > pkt_burst_checksum_forward(struct fwd_stream *fs) > > "m->l4_len=3D%d\n", > > m->l2_len, m->l3_len, m->l4_len); > > if ((tunnel =3D=3D 1) && > > - (testpmd_ol_flags & > TESTPMD_TX_OFFLOAD_VXLAN_CKSUM)) > > + (testpmd_ol_flags & > TESTPMD_TX_OFFLOAD_TUNNEL_CKSUM)) > > printf("tx: m->outer_l2_len=3D%d m- > >outer_l3_len=3D%d\n", > > m->outer_l2_len, m->outer_l3_len); > > if (tso_segsz !=3D 0) > > diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index > > f8b0740..09caa6a 100644 > > --- a/app/test-pmd/testpmd.h > > +++ b/app/test-pmd/testpmd.h > > @@ -125,10 +125,20 @@ struct fwd_stream { > > #define TESTPMD_TX_OFFLOAD_TCP_CKSUM 0x0004 > > /** Offload SCTP checksum in csum forward engine */ > > #define TESTPMD_TX_OFFLOAD_SCTP_CKSUM 0x0008 > > -/** Offload VxLAN checksum in csum forward engine */ > > -#define TESTPMD_TX_OFFLOAD_VXLAN_CKSUM 0x0010 > > +/** Offload tunneling packet checksum in csum forward engine */ > > +#define TESTPMD_TX_OFFLOAD_TUNNEL_CKSUM 0x0010 > > /** Insert VLAN header in forward engine */ > > #define TESTPMD_TX_OFFLOAD_INSERT_VLAN 0x0020 > > +/** > > + * Offload outer-IP checksum in csum forward engine > > + * for tunneling packet > > + */ > > +#define TESTPMD_TX_OFFLOAD_OUTER_IP_CKSUM 0x0040 > > +/** > > + * For a tunneling packet, user requests HW offload for its outer > > + * layer checksum, and don't care is it a tunneled packet or not. > > + */ > > +#define TESTPMD_TX_OFFLOAD_NON_TUNNEL_CKSUM 0x0080 > > > > /** > > * The data structure associated with each port. > > >=20 > For now, I did not check the implementation of the patch. I'm not sure I > understand the specifications, so I cannot check if the code conforms to = it. >=20 > How this patch is tested?=20 Yes, it is tested for i40e and ixgbe. > I think a report similar to > http://dpdk.org/ml/archives/dev/2014-November/007991.html would help to > verify that it works (at least on one driver), and to understand the test= -pmd API > and the different use cases. Ok, will send test report. > Regards, > Olivier