From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 7E7C7234 for ; Wed, 7 Jan 2015 03:04:01 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP; 06 Jan 2015 18:00:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,711,1413270000"; d="scan'208,217";a="657866221" Received: from pgsmsx103.gar.corp.intel.com ([10.221.44.82]) by fmsmga002.fm.intel.com with ESMTP; 06 Jan 2015 18:03:57 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by PGSMSX103.gar.corp.intel.com (10.221.44.82) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 7 Jan 2015 10:03:57 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.110]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.67]) with mapi id 14.03.0195.001; Wed, 7 Jan 2015 10:03:55 +0800 From: "Liu, Jijiang" To: 'Olivier MATZ' Thread-Topic: [dpdk-dev] [PATCH v3 0/3] enhance TX checksum command and csum forwarding engine Thread-Index: AQHQFSv0txinLaq/UEmWgzF3v0CZupyLMv5ggABvM4CAJx3DUA== Date: Wed, 7 Jan 2015 02:03:54 +0000 Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC01DA7699@SHSMSX101.ccr.corp.intel.com> References: <1418173403-30202-1-git-send-email-jijiang.liu@intel.com> <54896F4A.4070601@6wind.com> <1ED644BD7E0A5F4091CF203DAFB8E4CC01DA1B70@SHSMSX101.ccr.corp.intel.com> <548B18C9.3020408@6wind.com> In-Reply-To: <548B18C9.3020408@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3 0/3] enhance TX checksum command and csum forwarding engine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jan 2015 02:04:02 -0000 Hi Olivier, > -----Original Message----- > From: Olivier MATZ [mailto:olivier.matz@6wind.com] > Sent: Saturday, December 13, 2014 12:33 AM > To: Liu, Jijiang > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 0/3] enhance TX checksum command and > csum forwarding engine > > Hello, > > On 12/12/2014 04:48 AM, Liu, Jijiang wrote: > > The 'hw/sw' option is used to set/clear the flag of enabling TX tunnel= ing packet > checksum hardware offload in testpmd application. > > This is not clear at all. > In your command, there is (hw|sw|none). > Are you talking about inner or outer? > Is this command useful for any kind of packet? > How does it combine with "tx_checksum set outer-ip (hw|sw)"? > I rethink these TX checksum commands in this patch set and agree with you t= hat we should make some changes for having clear meaning for them. There are 3 commands in patch set as follows, 1. tx_checksum set tunnel (hw|sw|none) (port-id) Now I also think the command 1 may confuse user, they probably don't unders= tand why we need 'hw' or 'sw' option and when to use the two option, so I will replace the command with 'tx_checksum set hw-tunnel-mode (on|off)= (port-id)' command. 2. tx_checksum set outer-ip (hw|sw) (port-id) 3. tx_checksum set (ip|udp|tcp|sctp) (hw|sw) (port-id) The command 2 will be merged into command 3, the new command is ' tx_checks= um set (outer-ip|ip|udp|tcp|sctp) (hw|sw) (port-id)'. These most of the cases in http://dpdk.org/ml/archives/dev/2014-December/00= 9213.html will be covered by using the two commands The command 'tx_checksum set hw-tunnel-mode (on|off) (port-id)' is used to= set/clear TESTPMD_TX_OFFLOAD_TUNNEL_CKSUM flag. Actually, the PKT_TX_UDP_TUNNEL_PKT offload flag will be set if the testpmd= flag is set, which tell driver/HW treat that transmit packet as a tunneli= ng packet. When 'on' is set, which is able to meet Method B.1 and method C. When 'off' is set, the TESTPMD_TX_OFFLOAD_TUNNEL_CKSUM is not needed to set= , so the PKT_TX_UDP_TUNNEL_PKT offload flag is not needed to set, then HW = treat that transmit packet as a non-tunneling packet. It is able to meet M= ethod B.2. As to case A, I think it is not mandatory to cover it in csum fwd engine fo= r tunneling packet. Is the above description clear for you? > Regards, > Olivier