From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jijiang.liu@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 9AFF7594E
 for <dev@dpdk.org>; Mon, 18 May 2015 03:39:00 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga101.fm.intel.com with ESMTP; 17 May 2015 18:38:59 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,449,1427785200"; d="scan'208";a="494850908"
Received: from kmsmsx151.gar.corp.intel.com ([172.21.73.86])
 by FMSMGA003.fm.intel.com with ESMTP; 17 May 2015 18:38:58 -0700
Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by
 KMSMSX151.gar.corp.intel.com (172.21.73.86) with Microsoft SMTP Server (TLS)
 id 14.3.224.2; Mon, 18 May 2015 09:37:08 +0800
Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.120]) by
 shsmsx102.ccr.corp.intel.com ([169.254.2.109]) with mapi id 14.03.0224.002;
 Mon, 18 May 2015 09:37:07 +0800
From: "Liu, Jijiang" <jijiang.liu@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Thread-Topic: [dpdk-dev] [PATCH 01/10] examples/tep_termination:initialize
 the VXLAN sample
Thread-Index: AQHQj2pvw5UEcvGh40yh2iqzo4DmTZ2A9a6Q
Date: Mon, 18 May 2015 01:37:07 +0000
Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC0575696D@SHSMSX101.ccr.corp.intel.com>
References: <1431670141-7835-1-git-send-email-jijiang.liu@intel.com>
 <1431670141-7835-2-git-send-email-jijiang.liu@intel.com>
 <20150515165345.007a8919@urahara>
In-Reply-To: <20150515165345.007a8919@urahara>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 01/10] examples/tep_termination:initialize
 the VXLAN sample
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 18 May 2015 01:39:01 -0000

Hi Stephen,

Thanks for reviewing the patch.

> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Saturday, May 16, 2015 7:54 AM
> To: Liu, Jijiang
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 01/10] examples/tep_termination:initialize=
 the
> VXLAN sample
>=20
> I agree that this is great to see a real example of this
>=20
> On Fri, 15 May 2015 14:08:52 +0800
> Jijiang Liu <jijiang.liu@intel.com> wrote:
>=20
> > +static unsigned
> > +check_ports_num(unsigned nb_ports)
> > +{
> > +	unsigned valid_nb_ports =3D nb_ports;
> > +	unsigned portid;
> > +
> > +	if (nb_ports > nb_ports) {
> > +		RTE_LOG(INFO, VHOST_PORT, "\nSpecified port number(%u)
> exceeds total system port number(%u)\n",
> > +			nb_ports, nb_ports);
> > +		nb_ports =3D nb_ports;
>=20
> This looks repetative, and wrong, is it something to shut up a compiler w=
arning?
> or something that happened as result of global replace?

Yes, it happened as result of global replace. I will fix this in next  patc=
h version.