From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id E054E9A9E for ; Mon, 18 May 2015 04:23:14 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP; 17 May 2015 19:23:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,449,1427785200"; d="scan'208";a="572856922" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by orsmga003.jf.intel.com with ESMTP; 17 May 2015 19:23:12 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by PGSMSX101.gar.corp.intel.com (10.221.44.78) with Microsoft SMTP Server (TLS) id 14.3.224.2; Mon, 18 May 2015 10:23:11 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.120]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.180]) with mapi id 14.03.0224.002; Mon, 18 May 2015 10:23:09 +0800 From: "Liu, Jijiang" To: Stephen Hemminger , "He, Shaopeng" , Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] fm10k: support XEN domain0 Thread-Index: AQHQju0RgjUCeJmqD0KYdMzhp6npX519MduAgAPQIsA= Date: Mon, 18 May 2015 02:23:09 +0000 Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC0575760E@SHSMSX101.ccr.corp.intel.com> References: <1431680162-13704-1-git-send-email-shaopeng.he@intel.com> <20150515165733.7d5571e3@urahara> In-Reply-To: <20150515165733.7d5571e3@urahara> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] fm10k: support XEN domain0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 May 2015 02:23:15 -0000 Hi guys, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Saturday, May 16, 2015 7:58 AM > To: He, Shaopeng > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] fm10k: support XEN domain0 >=20 > On Fri, 15 May 2015 16:56:02 +0800 > Shaopeng He wrote: >=20 > > fm10k was failing to run in XEN domain0, as the physical memory for > > DMA should be allocated and translated in a different way for XEN > > domain0. So > > rte_memzone_reserve_bounded() should be used for DMA memory > > allocation, and rte_mem_phy2mch() should be used for DMA memory > > address translation to support running fm10k PMD in XEN domain0. > > > > Signed-off-by: Shaopeng He >=20 > I agree with Thomas that this code has spread everywhere and should be in= a > common spot. >=20 > Also, we discovered as part of the Xen net-front driver that it should be= a > runtime determination, not a config option! I also agree that it should be in a common spot. But it had better to apply the following Stephen's patch first. If so, Sha= openg just use the common function in the patch, which would be good. =20 http://dpdk.org/ml/archives/dev/2015-March/014992.html