From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jijiang.liu@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 674F75937
 for <dev@dpdk.org>; Mon, 18 May 2015 04:43:19 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga101.fm.intel.com with ESMTP; 17 May 2015 19:43:18 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,449,1427785200"; d="scan'208";a="572862386"
Received: from pgsmsx107.gar.corp.intel.com ([10.221.44.105])
 by orsmga003.jf.intel.com with ESMTP; 17 May 2015 19:43:17 -0700
Received: from shsmsx103.ccr.corp.intel.com (10.239.110.14) by
 PGSMSX107.gar.corp.intel.com (10.221.44.105) with Microsoft SMTP Server (TLS)
 id 14.3.224.2; Mon, 18 May 2015 10:42:12 +0800
Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.120]) by
 SHSMSX103.ccr.corp.intel.com ([169.254.4.23]) with mapi id 14.03.0224.002;
 Mon, 18 May 2015 10:42:11 +0800
From: "Liu, Jijiang" <jijiang.liu@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Thread-Topic: [dpdk-dev] [PATCH 01/10] examples/tep_termination:initialize
 the VXLAN sample
Thread-Index: AQHQj2qrbhhECaLmZEGSf2EaBFJut52BCPHQ
Date: Mon, 18 May 2015 02:42:10 +0000
Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC05757D1A@SHSMSX101.ccr.corp.intel.com>
References: <1431670141-7835-1-git-send-email-jijiang.liu@intel.com>
 <1431670141-7835-2-git-send-email-jijiang.liu@intel.com>
 <20150515165548.4e88b744@urahara>
In-Reply-To: <20150515165548.4e88b744@urahara>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 01/10] examples/tep_termination:initialize
 the VXLAN sample
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 18 May 2015 02:43:19 -0000



> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Saturday, May 16, 2015 7:56 AM
> To: Liu, Jijiang
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 01/10] examples/tep_termination:initialize=
 the
> VXLAN sample
>=20
> On Fri, 15 May 2015 14:08:52 +0800
> Jijiang Liu <jijiang.liu@intel.com> wrote:
>=20
> > +		while (dev_ll !=3D NULL) {
> > +			/*get virtio device ID*/
>=20
> Really minor style nit. Please put whitespace in comments.
> Do this instead.
> 	/* get virtio device ID */
>=20
> Also, the name virtio is confusing since it can be confused with KVM virt=
io.

Ok, will fix them in next version.