From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id EEDCC8DA7 for ; Wed, 4 Nov 2015 13:52:04 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP; 04 Nov 2015 04:52:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,243,1444719600"; d="scan'208";a="842368790" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga002.jf.intel.com with ESMTP; 04 Nov 2015 04:52:03 -0800 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 4 Nov 2015 04:52:03 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 4 Nov 2015 04:52:03 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.57]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.41]) with mapi id 14.03.0248.002; Wed, 4 Nov 2015 20:52:01 +0800 From: "Liu, Jijiang" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v3 6/8] driver/virtio:enqueue vhost TX offload Thread-Index: AQHRFu89DSl6C3bBZkC4lqvvuDZDwp6LMNoAgACb7zA= Date: Wed, 4 Nov 2015 12:52:00 +0000 Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC22BCFE40@SHSMSX101.ccr.corp.intel.com> References: <1446634456-413-1-git-send-email-jijiang.liu@intel.com> <1446634456-413-7-git-send-email-jijiang.liu@intel.com> <2611781.I9AKvK5K3K@xps13> In-Reply-To: <2611781.I9AKvK5K3K@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" , "Michael S. Tsirkin" Subject: Re: [dpdk-dev] [PATCH v3 6/8] driver/virtio:enqueue vhost TX offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Nov 2015 12:52:05 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, November 4, 2015 7:18 PM > To: Liu, Jijiang > Cc: dev@dpdk.org; Michael S. Tsirkin > Subject: Re: [dpdk-dev] [PATCH v3 6/8] driver/virtio:enqueue vhost=20 The following code is not in the patch 6, please review the latest patch se= t. > > + parse_ethernet(m, &l4_proto, &l4_hdr); > > + if (hdr->flags =3D=3D VIRTIO_NET_HDR_F_NEEDS_CSUM) { > > + if ((hdr->csum_start =3D=3D m->l2_len) && > > + (hdr->csum_offset =3D=3D offsetof(struct ipv4_hdr, > > + hdr_checksum))) > > + m->ol_flags |=3D PKT_TX_IP_CKSUM; > > + else if (hdr->csum_start =3D=3D (m->l2_len + m->l3_len)) { > > + switch (hdr->csum_offset) { > > + case (offsetof(struct tcp_hdr, cksum)): > > + if (l4_proto =3D=3D IPPROTO_TCP) > > + m->ol_flags |=3D PKT_TX_TCP_CKSUM; > > + break; > > + case (offsetof(struct udp_hdr, dgram_cksum)): > > + if (l4_proto =3D=3D IPPROTO_UDP) > > + m->ol_flags |=3D PKT_TX_UDP_CKSUM; > > + break; > > + case (offsetof(struct sctp_hdr, cksum)): > > + if (l4_proto =3D=3D IPPROTO_SCTP) > > + m->ol_flags |=3D PKT_TX_SCTP_CKSUM; > > + break; > > + default: > > + break; > > + } > > + } >=20 > The kernel doesn't work this way. > Please could you check that your virtio implementation works with a vanil= la > Linux with or without vhost? > Thanks This is vhost lib implementation, not virtio-net side. We have already validated with a vanilla Linux with or without virtio-net, = and it passed. Could you please review latest patch v3? Xu Qian can send the test report out. =20