From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jijiang.liu@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 692715921
 for <dev@dpdk.org>; Mon,  9 Nov 2015 09:18:53 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga102.fm.intel.com with ESMTP; 09 Nov 2015 00:18:53 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,265,1444719600"; d="scan'208";a="681231888"
Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205])
 by orsmga003.jf.intel.com with ESMTP; 09 Nov 2015 00:18:51 -0800
Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by
 fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Mon, 9 Nov 2015 00:18:51 -0800
Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by
 fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Mon, 9 Nov 2015 00:18:51 -0800
Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.83]) by
 SHSMSX152.ccr.corp.intel.com ([169.254.6.193]) with mapi id 14.03.0248.002;
 Mon, 9 Nov 2015 16:18:49 +0800
From: "Liu, Jijiang" <jijiang.liu@intel.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Thread-Topic: [dpdk-dev] [PATCH v3 8/8] examples/vhost:support TX offload in
 vhost sample
Thread-Index: AQHRFu9B3tJD2iqHg0yxH2kp7cPTv56SlwKAgADJdkA=
Date: Mon, 9 Nov 2015 08:18:48 +0000
Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC22BD9565@SHSMSX101.ccr.corp.intel.com>
References: <1446634456-413-1-git-send-email-jijiang.liu@intel.com>
 <1446634456-413-9-git-send-email-jijiang.liu@intel.com>
 <20151109041707.GJ2326@yliu-dev.sh.intel.com>
In-Reply-To: <20151109041707.GJ2326@yliu-dev.sh.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 8/8] examples/vhost:support TX offload in
 vhost sample
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Nov 2015 08:18:53 -0000

> >
> > -/* IPv4 Header */
> > -struct ipv4_hdr {
> > -	uint8_t  version_ihl;		/**< version and header length */
> > -	uint8_t  type_of_service;	/**< type of service */
> > -	uint16_t total_length;		/**< length of packet */
> > -	uint16_t packet_id;		/**< packet ID */
> > -	uint16_t fragment_offset;	/**< fragmentation offset */
> > -	uint8_t  time_to_live;		/**< time to live */
> > -	uint8_t  next_proto_id;		/**< protocol ID */
> > -	uint16_t hdr_checksum;		/**< header checksum */
> > -	uint32_t src_addr;		/**< source address */
> > -	uint32_t dst_addr;		/**< destination address */
> > -} __attribute__((__packed__));
>=20
>=20
> Minor nit: it's a cleanup, having nothing to do with this patch (to
> demonstrate TSO/CSUM). It belongs to another patch.
>=20
Ok, it could be a separate patch.