From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id B679A5A97 for ; Wed, 11 Nov 2015 09:53:12 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP; 11 Nov 2015 00:53:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,274,1444719600"; d="scan'208";a="848312949" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 11 Nov 2015 00:53:11 -0800 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 11 Nov 2015 00:53:11 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 11 Nov 2015 00:53:11 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.83]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.223]) with mapi id 14.03.0248.002; Wed, 11 Nov 2015 16:53:09 +0800 From: "Liu, Jijiang" To: Yuanhan Liu Thread-Topic: [dpdk-dev] [PATCH v4 7/8] virtio/lib:add virtio guest offload capabilities Thread-Index: AQHRHEv/9kTOw3jhcUuIrjChZUXedp6V9/cAgACHpbD//3v+gIAAh9Ng Date: Wed, 11 Nov 2015 08:53:08 +0000 Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC22BDA74A@SHSMSX101.ccr.corp.intel.com> References: <1447224046-1169-1-git-send-email-jijiang.liu@intel.com> <1447224046-1169-8-git-send-email-jijiang.liu@intel.com> <20151111083118.GA2326@yliu-dev.sh.intel.com> <1ED644BD7E0A5F4091CF203DAFB8E4CC22BDA719@SHSMSX101.ccr.corp.intel.com> <20151111084419.GC2326@yliu-dev.sh.intel.com> In-Reply-To: <20151111084419.GC2326@yliu-dev.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" , "Michael S. Tsirkin" Subject: Re: [dpdk-dev] [PATCH v4 7/8] virtio/lib:add virtio guest offload capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Nov 2015 08:53:13 -0000 > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Wednesday, November 11, 2015 4:44 PM > To: Liu, Jijiang > Cc: Michael S. Tsirkin; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 7/8] virtio/lib:add virtio guest offloa= d > capabilities >=20 > On Wed, Nov 11, 2015 at 08:38:29AM +0000, Liu, Jijiang wrote: > > > > > > > -----Original Message----- > > > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > > > Sent: Wednesday, November 11, 2015 4:31 PM > > > To: Liu, Jijiang; Michael S. Tsirkin > > > Cc: dev@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH v4 7/8] virtio/lib:add virtio guest > > > offload capabilities > > > > > > On Wed, Nov 11, 2015 at 02:40:45PM +0800, Jijiang Liu wrote: > > > > Add virtio guest offload capabilities. > > > > > > > > Signed-off-by: Jijiang Liu > > > > --- > > > > lib/librte_vhost/virtio-net.c | 5 ++++- > > > > 1 files changed, 4 insertions(+), 1 deletions(-) > > > > > > > > diff --git a/lib/librte_vhost/virtio-net.c > > > > b/lib/librte_vhost/virtio-net.c index 81bd309..839a333 100644 > > > > --- a/lib/librte_vhost/virtio-net.c > > > > +++ b/lib/librte_vhost/virtio-net.c > > > > @@ -80,7 +80,10 @@ static struct virtio_net_config_ll *ll_root; > > > > (1ULL << > > > VHOST_USER_F_PROTOCOL_FEATURES) | \ > > > > (1ULL << VIRTIO_NET_F_HOST_TSO4) | \ > > > > (1ULL << VIRTIO_NET_F_HOST_TSO6) | \ > > > > - (1ULL << VIRTIO_NET_F_CSUM)) > > > > + (1ULL << VIRTIO_NET_F_CSUM) | \ > > > > + (1ULL << VIRTIO_NET_F_GUEST_CSUM) | \ > > > > + (1ULL << VIRTIO_NET_F_GUEST_TSO4) | \ > > > > + (1ULL << VIRTIO_NET_F_GUEST_TSO6)) > > > > > > I don't think we need that, and it might be wrong to set those fields= at > vhost. > > > > > > And, TBH, I am not 100% sure that I understand what those flags > > > truely are and for. All I know is that they seem have something to > > > do with QEMU/TAP device. > > > > According to virtio standard, those fileds should be set. >=20 > If so, you'd better quote them here, or even to your patch commit. In the Virtual I/O Device (VIRTIO) Version 1.0 Committee Specification 02,= =20 (1) VIRTIO_NET_F_GUEST_CSUM (1) Driver handles packets with partial checksu= m. (2) If the VIRTIO_NET_F_GUEST_CSUM feature was negotiated, the VIRTIO_NET_H= DR_F_NEEDS_- CSUM bit in flags MAY be set: if so, the checksum on the packet is incomple= te and csum_start and csum_offset indicate how to calculate it (see Packet Transmission point= 1). (3) If the VIRTIO_NET_F_GUEST_TSO4, TSO6 or UFO options were negotiated, th= en gso_type MAY be something other than VIRTIO_NET_HDR_GSO_NONE, and gso_size field ind= icates the desired MSS (see Packet Transmission point 2). The information can be included in the next version of patch set. > --yliu >=20 > > Yes, I'd like to listen other guys comments. > > > > > Hopefully the virtio expert, Michael, could shine some lights on that= . > > > > > > --yliu > > > > > > > > > > > static uint64_t VHOST_FEATURES =3D VHOST_SUPPORTED_FEATURES; > > > > > > > > -- > > > > 1.7.7.6