From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 29CAE9578 for ; Mon, 7 Dec 2015 08:48:01 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP; 06 Dec 2015 23:47:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,393,1444719600"; d="scan'208";a="866125248" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga002.jf.intel.com with ESMTP; 06 Dec 2015 23:47:59 -0800 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 6 Dec 2015 23:47:59 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 6 Dec 2015 23:47:59 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.83]) by shsmsx102.ccr.corp.intel.com ([169.254.2.42]) with mapi id 14.03.0248.002; Mon, 7 Dec 2015 15:47:57 +0800 From: "Liu, Jijiang" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] doc: announce ABI change for struct rte_eth_conf Thread-Index: AQHRMJ3o2fi3UA0L2Ei9DPT7atSINp6+3chg//984YCAAMqhkA== Date: Mon, 7 Dec 2015 07:47:56 +0000 Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC22BE51F5@SHSMSX101.ccr.corp.intel.com> References: <1449457307-15206-1-git-send-email-jijiang.liu@intel.com> <9803987.ILZ5mdRcVm@xps13> <1ED644BD7E0A5F4091CF203DAFB8E4CC22BE50BE@SHSMSX101.ccr.corp.intel.com> <3679869.2UDrnTTX50@xps13> In-Reply-To: <3679869.2UDrnTTX50@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for struct rte_eth_conf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Dec 2015 07:48:01 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Monday, December 07, 2015 11:40 AM > To: Liu, Jijiang > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for struct > rte_eth_conf >=20 > 2015-12-07 03:30, Liu, Jijiang: > > Hi Thomas, > > > > > -----Original Message----- > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > Sent: Monday, December 07, 2015 11:17 AM > > > To: Liu, Jijiang > > > Cc: dev@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for struct > > > rte_eth_conf > > > > > > 2015-12-07 11:01, Jijiang Liu: > > > > +* ABI changes are planned for struct rte_eth_conf in order to > > > > +support > > > > + tunneling packet configuration in unified tunneling API. The > > > > +release 2.2 > > > does not contain these ABI > > > > + changes, but release 2.3 will, and no backwards compatibility is > planned. > > > > > > Please, more details would be appreciated. > > > We need to decide whether an ABI deprecation is the right choice. > > > > * ABI changes are planned for struct rte_eth_conf in order to support > > tunneling packet configuration in unified tunneling APIs, which is th= e > rte_eth_dev_tunnel_configure > > (uint8_t port_id, uint16_t rx_q, uint16_t tx_q, rte_eth_tunnel_conf * > tunnel_conf) API is planned to add. > > and the 'tunnel_conf' shloud be stored in global 'rte_eth_conf'. > > The release 2.2 does not contain these ABI change, but release 2.3 wi= ll, > and no backwards compatibility is planned. > > > > Is it enough clear? >=20 > No, I think we need an explanation in the commit message of what is the > purpose of rte_eth_dev_tunnel_configure() and tunnel_conf. Ok, will do. > Ideally, an RFC patch would help. I'm working on RFC patch, but it probably will miss merge timeslot of this= release.