From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 475EB282 for ; Tue, 15 Dec 2015 04:00:23 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP; 14 Dec 2015 19:00:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,430,1444719600"; d="scan'208";a="871565359" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 14 Dec 2015 19:00:22 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 14 Dec 2015 19:00:21 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.190]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.28]) with mapi id 14.03.0248.002; Tue, 15 Dec 2015 11:00:19 +0800 From: "Liu, Jijiang" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v3] doc: announce ABI change for struct rte_eth_conf Thread-Index: AQHRNkPqc61+oU44h0OWcsv7s6i08Z7KEF2AgAE/2CA= Date: Tue, 15 Dec 2015 03:00:19 +0000 Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC22BF03B5@SHSMSX101.ccr.corp.intel.com> References: <1450079331-28139-1-git-send-email-jijiang.liu@intel.com> <1610909.TYWkT8rdxQ@xps13> In-Reply-To: <1610909.TYWkT8rdxQ@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3] doc: announce ABI change for struct rte_eth_conf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Dec 2015 03:00:23 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Monday, December 14, 2015 11:10 PM > To: Liu, Jijiang > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] doc: announce ABI change for struct > rte_eth_conf >=20 > > And tunneling packet encapsulation operation will benefit from the chan= ge. >=20 > Sorry, I don't understand what you mean. > Maybe others have a clue? We want to add functions of tunneling packet decapsulation/encapsulation a= s APIs into DPDK, and it had better store tunnel configuration in a device'= s configuration, as a result, outer src/dst MAC address, outer src/dst IP a= ddress and others can be stored for a pair of queues.=20 The stored configuration can be used when encapsulating a tunneling packet= for sending out via a specific queue. And for RX side, we can use flow director or tunnel filter mechanism to gua= rantee a specific flow enter the a specific. For example, We do the following configuration, rx_queue: 1 tx_queue: 1 Tunnel id: 1000 Outer Src MAC:=20 Outer dst MAC: 66.55.44.33.22.11 Outer Src IP:=20 Outer dst IP: 192.168.10.2 inner dst MAC: 22.33.44.55.66.77 And set RX classification condition for RX queue 1: Outer dst MAC + T= unnel id + inner dst MAC ( or 5 tuples), and decapsulate the tunneling pac= ket and save some fields in the 'tunnel_conf' in the ' rte_eth_conf ', then these stored configuration can be used when encapsulating a tun= neling packet for sending out via TX queue 1. =20 > > The change of struct 'rte_eth_conf' like below, but it have not finaliz= ed yet. > > struct rte_eth_conf { > > ... > > =09 > > struct rte_eth_tunnel_conf *tunnel_conf[RTE_MAX_QUEUES_PER_PORT]; > > /**< Tunnel configuration. */ > > }; > This rte_eth_conf struct is an input for rte_eth_dev_configure(). > Should we add some fields which are not used by rte_eth_dev_configure() > but configured through rte_eth_dev_filter_ctrl() instead? The tunnel configuration is not just for classification, we also need them = to do encapsulation operation.=20