DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Rao, Nikhil" <nikhil.rao@intel.com>
To: "Varghese, Vipin" <vipin.varghese@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Jain, Deepak K" <deepak.k.jain@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] test/eventdev: add multi port test to suite
Date: Mon, 21 May 2018 11:15:23 +0000	[thread overview]
Message-ID: <1F668163772FA946975B9466A9DFF729EB58279B@ORSMSX107.amr.corp.intel.com> (raw)
In-Reply-To: <1526900209-91364-1-git-send-email-vipin.varghese@intel.com>

Hi Vipin,


> -----Original Message-----
> From: Varghese, Vipin
> Sent: Monday, May 21, 2018 4:27 PM
> To: dev@dpdk.org; Rao, Nikhil <nikhil.rao@intel.com>; Jain, Deepak K
> <deepak.k.jain@intel.com>
> Cc: Varghese, Vipin <vipin.varghese@intel.com>
> Subject: [PATCH v2] test/eventdev: add multi port test to suite
> 
> Add a new test to enhance the test suite, to allow multiple eth ports rx queue
> to be added to rx bridge adapter. Update the test function to reflect change
> of port index from 8 to 16 bit
> 
> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> Acked-by: Nikhil Rao <nikhil.rao@intel.com>
> ---
> 
> Changes in V2:
> - reprhased the variable names for dtiver - Nikhil Rao
> - Initialization removed for driver_name - Nikhil Rao
> - removed adapter capability instance - Nikhil Rao
> - reprhased comment - Nikhil Rao
> ---
>  test/test/test_event_eth_rx_adapter.c | 78
> ++++++++++++++++++++++++++++++++++-
>  1 file changed, 77 insertions(+), 1 deletion(-)
> 
> diff --git a/test/test/test_event_eth_rx_adapter.c
> b/test/test/test_event_eth_rx_adapter.c
> 
</sniped>

> +
> +	err = rte_event_eth_rx_adapter_caps_get(TEST_DEV_ID,
> TEST_ETHDEV_ID,
> +			&cap);
> +	TEST_ASSERT(err == 0, "Expected 0 got %d", err);
> +
You can remove the call to caps_get, cap isn't referenced.

Nikhil

      reply	other threads:[~2018-05-21 11:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-21 10:56 Vipin Varghese
2018-05-21 11:15 ` Rao, Nikhil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1F668163772FA946975B9466A9DFF729EB58279B@ORSMSX107.amr.corp.intel.com \
    --to=nikhil.rao@intel.com \
    --cc=deepak.k.jain@intel.com \
    --cc=dev@dpdk.org \
    --cc=vipin.varghese@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).