From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 8B6162C38 for ; Thu, 23 Aug 2018 03:48:21 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Aug 2018 18:48:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,276,1531810800"; d="scan'208";a="85647740" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by orsmga002.jf.intel.com with ESMTP; 22 Aug 2018 18:48:20 -0700 Received: from orsmsx116.amr.corp.intel.com (10.22.240.14) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 22 Aug 2018 18:48:20 -0700 Received: from orsmsx110.amr.corp.intel.com ([169.254.10.41]) by ORSMSX116.amr.corp.intel.com ([169.254.7.225]) with mapi id 14.03.0319.002; Wed, 22 Aug 2018 18:48:20 -0700 From: "Rao, Nikhil" To: Pavan Nikhilesh , "jerin.jacob@caviumnetworks.com" , "olivier.matz@6wind.com" CC: "dev@dpdk.org" , "Rao, Nikhil" Thread-Topic: [PATCH v2 4/4] eventdev: add auto test for eth Tx adapter Thread-Index: AQHUOjMPXnNxqpFuBkClhsIV4zymoqTMacaAgAASoOA= Date: Thu, 23 Aug 2018 01:48:19 +0000 Message-ID: <1F668163772FA946975B9466A9DFF729ED33F804@ORSMSX110.amr.corp.intel.com> References: <1534479652-80182-1-git-send-email-nikhil.rao@intel.com> <1534479652-80182-4-git-send-email-nikhil.rao@intel.com> <20180817115515.GA4360@ltp-pvn> <6cd55ea9-fb68-73a4-43bd-dcd6772247cf@intel.com> <20180822162307.GA18299@ltp-pvn> In-Reply-To: <20180822162307.GA18299@ltp-pvn> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.22.254.139] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 4/4] eventdev: add auto test for eth Tx adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2018 01:48:22 -0000 > -----Original Message----- > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com] > Sent: Wednesday, August 22, 2018 9:53 PM > To: Rao, Nikhil ; jerin.jacob@caviumnetworks.com; > olivier.matz@6wind.com > Cc: dev@dpdk.org > Subject: Re: [PATCH v2 4/4] eventdev: add auto test for eth Tx adapter >=20 > On Wed, Aug 22, 2018 at 09:43:02PM +0530, Rao, Nikhil wrote: > > > > + ev_qid =3D qcnt; > > > > + qconf.nb_atomic_flows =3D dev_info.max_event_queue_flows; > > > > + qconf.nb_atomic_order_sequences =3D 32; > > > > + qconf.schedule_type =3D RTE_SCHED_TYPE_ATOMIC; > > > > + qconf.priority =3D RTE_EVENT_DEV_PRIORITY_HIGHEST; > > > > + qconf.event_queue_cfg =3D RTE_EVENT_QUEUE_CFG_SINGLE_LINK; > > > > + err =3D rte_event_queue_setup(TEST_DEV_ID, ev_qid, &qconf); > > > > + TEST_ASSERT_SUCCESS(err, "Failed to setup queue %u", > > > > + ev_qid); > > > > > > On reconfigure, setup all the ports and queues so that the newly > > > configured values are seen by them. > > > > Is that required since dev_conf matches dev_info except for the number > > of queues ? >=20 > Some drivers require this as without port setup newly configured queues > might not be visible. >=20 OK. > > > > > > > > > + > > > > + err =3D rte_event_port_link(TEST_DEV_ID, ev_port, &ev_qid, = NULL, > 1); > > > > + TEST_ASSERT(err =3D=3D 1, "Failed to link queue port %u", > > > > + ev_port); > > > > + > > > > + err =3D rte_event_eth_tx_adapter_start(TEST_INST_ID); > > > > + TEST_ASSERT(err =3D=3D 0, "Expected 0 got %d", err); > > > > + > > > > + err =3D rte_event_dev_service_id_get(0, &eid); > > > > + TEST_ASSERT(err =3D=3D 0, "Expected 0 got %d", err); > > > > > > An event device might not be needing a service core, check the > > > capabilities before requesting service id above. > > > > > > > The internal_port capability is checked at the beginning of the > > function, if its not set, I think its Ok to assume that we need a > > service core ? >=20 > That check is to see if TX adapter requires service core, the above one i= s > checking if eventdev requires serivce core. Got it, I was misreading the comment. Thanks, Nikhil