From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id D74EE5592 for ; Wed, 3 Oct 2018 10:47:27 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Oct 2018 01:47:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,335,1534834800"; d="scan'208";a="88759448" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by orsmga003.jf.intel.com with ESMTP; 03 Oct 2018 01:47:26 -0700 Received: from orsmsx107.amr.corp.intel.com ([169.254.1.14]) by ORSMSX109.amr.corp.intel.com ([169.254.11.251]) with mapi id 14.03.0319.002; Wed, 3 Oct 2018 01:47:26 -0700 From: "Rao, Nikhil" To: Pavan Nikhilesh CC: "Van Haaren, Harry" , "anoob.joseph@caviumnetworks.com" , "dev@dpdk.org" , Jerin Jacob Thread-Topic: [PATCH v2] examples/eventdev_pipeline: add Tx adapter support Thread-Index: AQHUVZhoDCxUBE5VtUiEyuDn00PfE6UGA1oAgAcRPfA= Date: Wed, 3 Oct 2018 08:47:25 +0000 Message-ID: <1F668163772FA946975B9466A9DFF729ED364733@ORSMSX107.amr.corp.intel.com> References: <20180905134554.25243-1-pbhagavatula@caviumnetworks.com> <20180924101208.7350-1-pbhagavatula@caviumnetworks.com> <20180928111542.GA8468@jerin> In-Reply-To: <20180928111542.GA8468@jerin> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjQxZDg0NGQtMTg4OS00NzMwLWIwNDMtMTg2NjFhOTFjMGE2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQlJBVG4ydXl4OWJwRmtaOXY3dktpOHFLaGt1d1RHeEQxK0FMMFwvWnhsZktURmM0bUtuUm9jTXd3Qkp4eWlUcGYifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.22.254.140] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] examples/eventdev_pipeline: add Tx adapter support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2018 08:47:28 -0000 > -----Original Message----- > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Friday, September 28, 2018 4:46 PM > To: Rao, Nikhil > Cc: Pavan Nikhilesh ; Van Haaren, > Harry ; anoob.joseph@caviumnetworks.com; > dev@dpdk.org > Subject: Re: [PATCH v2] examples/eventdev_pipeline: add Tx adapter suppor= t >=20 > -----Original Message----- > > Date: Wed, 26 Sep 2018 18:26:37 +0530 > > From: "Rao, Nikhil" > > To: Pavan Nikhilesh , > > jerin.jacob@caviumnetworks.com, harry.van.haaren@intel.com, > > anoob.joseph@caviumnetworks.com > > CC: dev@dpdk.org, "Rao, Nikhil" > > Subject: Re: [PATCH v2] examples/eventdev_pipeline: add Tx adapter > > support > > User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) > > Gecko/20100101 > > Thunderbird/60.0 > > > > On 9/24/2018 3:42 PM, Pavan Nikhilesh wrote: > > > Redo the worker pipelines and offload transmission to service cores > > > seamlessly through Tx adapter. > > > > > > Signed-off-by: Pavan Nikhilesh > > > --- > > > v2 Changes: > > > - Updated enqueue,dequeue depth thresholds. > > > - remove redundant capability checks. > > > > Reviewed-by: Nikhil Rao > > Tested-by: Nikhil Rao >=20 >=20 > Applied to dpdk-next-eventdev/master. Thanks. >=20 Hi Pavan, A couple of questions: 1. For the generic pipeline case with the SW PMD, the tx adapter port's de= fault dequeue depth value causes performance regression from ~12 mpps to 7= mpps. While the -c command line argument is also applicable to the tx adapt= er's port, since packet flow to the tx adapter port is of a different natu= re than the worker ports, how about adding the dequeue depth for the tx ad= apter port as a separate command line argument with a default value of 128 = ? 2. -n parameter and stats for the generic pipeline that were available in = the app previously do not work, do you plan to add this functionality ?=20 Thanks, Nikhil