From: "Rao, Nikhil" <nikhil.rao@intel.com>
To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
"Jerin Jacob Kollanukkaran" <jerinj@marvell.com>,
"Van Haaren, Harry" <harry.van.haaren@intel.com>,
"Carrillo, Erik G" <erik.g.carrillo@intel.com>,
"Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>,
"Mcnamara, John" <john.mcnamara@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 2/3] examples/eventdev: start ethdev after eth adapter setup
Date: Wed, 13 Mar 2019 13:10:01 +0000 [thread overview]
Message-ID: <1F668163772FA946975B9466A9DFF729EDDE00F8@ORSMSX122.amr.corp.intel.com> (raw)
In-Reply-To: <20190312204037.16141-2-pbhagavatula@marvell.com>
> -----Original Message-----
> From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavatula@marvell.com]
> Sent: Wednesday, March 13, 2019 2:11 AM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Van Haaren, Harry
> <harry.van.haaren@intel.com>; Rao, Nikhil <nikhil.rao@intel.com>; Carrillo,
> Erik G <erik.g.carrillo@intel.com>; Gujjar, Abhinandan S
> <abhinandan.gujjar@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>
> Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula
> <pbhagavatula@marvell.com>
> Subject: [dpdk-dev] [PATCH v3 2/3] examples/eventdev: start ethdev after
> eth adapter setup
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Start ethdev after the Rx/Tx adapter setup is complete as in some
> architectures it might lead to undefined behaviour or events being dropped.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
> v3 Changes:
> - add the same changes in examples/eventdev_pipeline
>
> examples/eventdev_pipeline/main.c | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/examples/eventdev_pipeline/main.c
> b/examples/eventdev_pipeline/main.c
> index 92e08bc0c..22ea75e7b 100644
> --- a/examples/eventdev_pipeline/main.c
> +++ b/examples/eventdev_pipeline/main.c
> @@ -316,11 +316,6 @@ port_init(uint8_t port, struct rte_mempool
> *mbuf_pool)
> return retval;
> }
>
> - /* Start the Ethernet port. */
> - retval = rte_eth_dev_start(port);
> - if (retval < 0)
> - return retval;
> -
> /* Display the port MAC address. */
> struct ether_addr addr;
> rte_eth_macaddr_get(port, &addr);
> @@ -440,6 +435,7 @@ main(int argc, char **argv) {
> struct worker_data *worker_data;
> uint16_t num_ports;
> + uint16_t portid;
> int lcore_id;
> int err;
>
> @@ -507,6 +503,14 @@ main(int argc, char **argv)
> init_ports(num_ports);
> fdata->cap.adptr_setup(num_ports);
>
> + /* Start the Ethernet port. */
> + RTE_ETH_FOREACH_DEV(portid) {
> + err = rte_eth_dev_start(portid);
> + if (err < 0)
> + rte_exit(EXIT_FAILURE, "Error starting ethdev %d\n",
> + portid);
> + }
> +
Reviewed-by: Nikhil Rao <nikhil.rao@intel.com>
> int worker_idx = 0;
> RTE_LCORE_FOREACH_SLAVE(lcore_id) {
> if (lcore_id >= MAX_NUM_CORE)
> --
> 2.21.0
next prev parent reply other threads:[~2019-03-13 13:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 20:00 [dpdk-dev] [PATCH 1/2] app/eventdev: start event producers after eventdev is started Pavan Nikhilesh Bhagavatula
2019-02-27 20:00 ` [dpdk-dev] [PATCH 2/2] doc: add notes regarding eventdev producer consumer dependency Pavan Nikhilesh Bhagavatula
2019-03-05 15:15 ` Jerin Jacob Kollanukkaran
2019-03-05 23:52 ` Carrillo, Erik G
2019-03-06 5:32 ` Gujjar, Abhinandan S
2019-03-08 18:24 ` [dpdk-dev] [PATCH 1/2] app/eventdev: start event producers after eventdev is started Jerin Jacob Kollanukkaran
2019-03-11 7:59 ` [dpdk-dev] [PATCH v2 1/2] app/eventdev: start event producers after eventdev Pavan Nikhilesh Bhagavatula
2019-03-11 7:59 ` [dpdk-dev] [PATCH v2 2/2] doc: add notes about eventdev producer consumer dependency Pavan Nikhilesh Bhagavatula
2019-03-12 20:41 ` [dpdk-dev] [PATCH v3 1/3] app/eventdev: start event producers after eventdev Pavan Nikhilesh Bhagavatula
2019-03-12 20:41 ` [dpdk-dev] [PATCH v3 2/3] examples/eventdev: start ethdev after eth adapter setup Pavan Nikhilesh Bhagavatula
2019-03-13 13:10 ` Rao, Nikhil [this message]
2019-03-12 20:41 ` [dpdk-dev] [PATCH v3 3/3] doc: add notes about eventdev producer consumer dependency Pavan Nikhilesh Bhagavatula
2019-03-13 22:22 ` Carrillo, Erik G
2019-03-13 22:22 ` Carrillo, Erik G
2019-03-14 16:17 ` Jerin Jacob Kollanukkaran
2019-03-14 16:17 ` Jerin Jacob Kollanukkaran
2019-03-14 5:03 ` Gujjar, Abhinandan S
2019-03-14 5:03 ` Gujjar, Abhinandan S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1F668163772FA946975B9466A9DFF729EDDE00F8@ORSMSX122.amr.corp.intel.com \
--to=nikhil.rao@intel.com \
--cc=abhinandan.gujjar@intel.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=harry.van.haaren@intel.com \
--cc=jerinj@marvell.com \
--cc=john.mcnamara@intel.com \
--cc=pbhagavatula@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).