From: "Venkatesan, Venky" <venky.venkatesan@intel.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
David Marchand <david.marchand@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH RFC] eal: change default per socket memory allocation
Date: Fri, 2 May 2014 09:05:02 +0000 [thread overview]
Message-ID: <1FD9B82B8BF2CF418D9A1000154491D97409DBDD@ORSMSX102.amr.corp.intel.com> (raw)
In-Reply-To: <C6ECDF3AB251BE4894318F4E45123697592AB0F9@IRSMSX101.ger.corp.intel.com>
Agree with Anatoly - I would much rather not change legacy option behaviour that has existed for a while, especially when --socket-mem is available to do exactly what is needed.
-Venky
-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Burakov, Anatoly
Sent: Friday, May 02, 2014 1:54 AM
To: Burakov, Anatoly; David Marchand; dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH RFC] eal: change default per socket memory allocation
Hi again David/Didier,
> Can I suggest to do an RTE_MAX between (internal_config.memory -
> total_mem) and (internal_config.memory * cpu_per_socket[socket_id] +
> rte_lcore_count() - 1) / rte_lcore_count() ? I don't think it's a good
> idea to go over the requested amount. Let the last core have a chance
> of reserving slightly less memory than other cores, but don't let it
> go over the limit. If specific memory constraints are required, let
> the user use --socket-mem instead.
Sorry for spamming, but now that I think of it, I don't believe this change makes much sense. If the user wants memory on specific sockets, there's already --socket-mem option. If the user doesn't care, there's -m option, which gives the user memory from whatever sockets it is available. With this change applied, DPDK will fail when run with -m switch under certain circumstances (e.g. cores from socket 0 present in the coremask but no memory left on socket 0), which is quite the opposite of a simple "give me n megs, I don't care where it comes from" option -m is providing.
Best regards,
Anatoly Burakov
DPDK SW Engineer
--------------------------------------------------------------
Intel Shannon Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 Business address: Dromore House, East Park, Shannon, Co. Clare
next prev parent reply other threads:[~2014-05-02 9:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 14:15 David Marchand
2014-05-01 16:06 ` Burakov, Anatoly
2014-05-02 8:54 ` Burakov, Anatoly
2014-05-02 9:05 ` Venkatesan, Venky [this message]
2014-05-05 9:26 ` David Marchand
2014-05-06 10:05 ` Burakov, Anatoly
2014-05-06 15:18 ` Thomas Monjalon
2014-05-06 15:56 ` Burakov, Anatoly
2014-05-07 14:56 ` Venkatesan, Venky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1FD9B82B8BF2CF418D9A1000154491D97409DBDD@ORSMSX102.amr.corp.intel.com \
--to=venky.venkatesan@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).