From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 8CE9F6895 for ; Thu, 22 May 2014 18:09:16 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 22 May 2014 09:09:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.98,888,1392192000"; d="scan'208";a="543431714" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by fmsmga002.fm.intel.com with ESMTP; 22 May 2014 09:09:17 -0700 Received: from orsmsx102.amr.corp.intel.com ([169.254.1.253]) by ORSMSX108.amr.corp.intel.com ([169.254.4.68]) with mapi id 14.03.0123.003; Thu, 22 May 2014 09:09:16 -0700 From: "Venkatesan, Venky" To: Thomas Monjalon , "Ananyev, Konstantin" , "Shaw, Jeffrey B" , "Richardson, Bruce" , "nhorman@tuxdriver.com" , "stephen@networkplumber.org" Thread-Topic: [PATCH v2 00/17] add TSO support Thread-Index: AQHPdc8exlrZTHQvBECJ3JdEnvIAvJtMwyQQ Date: Thu, 22 May 2014 16:09:16 +0000 Message-ID: <1FD9B82B8BF2CF418D9A1000154491D9740B9074@ORSMSX102.amr.corp.intel.com> References: <1400507789-18453-1-git-send-email-olivier.matz@6wind.com> <466924555.DZ26nc55Es@xps13> In-Reply-To: <466924555.DZ26nc55Es@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.138] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 00/17] add TSO support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 May 2014 16:09:17 -0000 Thomas,=20 It's because we haven't gotten to testing the patch yet, and figuring out a= ll the problems. Putting it in and modifying MBUF needs a bit of time - one= other option that I've looked at is to let the transmit offload parts (exc= ept for the VLAN) flow onto the second cache line. That doesn't seem to hav= e a performance hit at this point - since it's going to be populated before= calling transmit anyway, it's cache hot. Have we thought of simply doing t= hat instead of these changes that have net negative side effects in terms o= f mbuf mods? Regards,=20 -Venky -----Original Message----- From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]=20 Sent: Thursday, May 22, 2014 8:02 AM To: Ananyev, Konstantin; Shaw, Jeffrey B; Richardson, Bruce; Venkatesan, Ve= nky; nhorman@tuxdriver.com; stephen@networkplumber.org Cc: Olivier Matz; dev@dpdk.org Subject: Re: [PATCH v2 00/17] add TSO support There were many comments on the first version of this serie, and there is n= o comment on this second version. So I understand everyone is OK with it and it can be applied in the git tre= e. I'll wait 1 day more. Feel free to comment or acknowledge. -- Thomas