From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 8A8CE530A for ; Fri, 2 Sep 2016 14:59:55 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP; 02 Sep 2016 05:59:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,270,1470726000"; d="scan'208";a="163838523" Received: from shwdeisgchi083.ccr.corp.intel.com (HELO [10.239.67.193]) ([10.239.67.193]) by fmsmga004.fm.intel.com with ESMTP; 02 Sep 2016 05:59:52 -0700 To: Ferruh Yigit , dev@dpdk.org References: <1472696197-37614-1-git-send-email-jianfeng.tan@intel.com> <83ce801f-c031-de38-1a0f-b1841b561b69@intel.com> Cc: david.marchand@6wind.com, stephen@networkplumber.org, Thomas Monjalon From: "Tan, Jianfeng" Message-ID: <1a051342-2cb0-b698-f629-d569eac7014d@intel.com> Date: Fri, 2 Sep 2016 20:59:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <83ce801f-c031-de38-1a0f-b1841b561b69@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC] igb_uio: deprecate iomem and ioport mapping X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Sep 2016 12:59:56 -0000 On 9/2/2016 8:31 PM, Ferruh Yigit wrote: > On 9/1/2016 3:16 AM, Jianfeng Tan wrote: >> Previously in igb_uio, iomem is mapped, and both ioport and io mem >> are recorded into uio framework, which is duplicated and makes the >> code too complex. >> >> For iomem, DPDK user space code never opens or reads files under >> /sys/pci/bus/devices/xxxx:xx:xx.x/uio/uioY/maps/. Instead, >> /sys/pci/bus/devices/xxxx:xx:xx.x/resourceY are used to map device >> memory. >> >> For ioport, non-x86 platforms cannot read from files under >> /sys/pci/bus/devices/xxxx:xx:xx.x/uio/uioY/portio/ directly, because >> non-x86 platforms need to map port region for access in user space, >> see non-x86 version pci_uio_ioport_map(). x86 platforms can use the >> the same way as uio_pci_generic. >> >> This patch deprecates iomem and ioport mapping in igb_uio kernel >> module, and adjusts the iomem implementation in both igb_uio and >> uio_pci_generic: >> - for x86 platform, get ports info from /proc/ioports; >> - for non-x86 platform, map and get ports info by pci_uio_ioport_map(). >> >> Note: this will affect those applications who are using files under >> /sys/pci/bus/devices/xxxx:xx:xx.x/uio/uioY/maps/ and >> /sys/pci/bus/devices/xxxx:xx:xx.x/uio/uioY/portio/. >> >> Signed-off-by: Jianfeng Tan >> --- > I think it is good idea to simplify to code, that piece looks like can > go away. > > But since sysfs interface exposed to the world, anybody can be using it, > > what about this: for this release keep this patch as RFC and send > another deprecation notice patch? Thank you Ferruh! Sounds good to me. And I will send out a deprecation notice patch later. Thanks, Jianfeng > And apply this patch in the following release (17.02). > > Thanks, > ferruh